Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13pt] Zkopru - refine TxBuilder.build() and add more test cases #409

Open
KimiWu123 opened this issue Oct 31, 2022 · 1 comment
Open

[13pt] Zkopru - refine TxBuilder.build() and add more test cases #409

KimiWu123 opened this issue Oct 31, 2022 · 1 comment
Assignees
@KimiWu123

Comments

@KimiWu123
Copy link
Contributor

found this bug, KimiWu123@12da771#r1009003491. TLDR, we didn't calculate remaining utxo correctly.

We should add more test scenarios and refactor it bcs this function is the too long.
@KimiWu123 KimiWu123 mentioned this issue Oct 31, 2022
Closed
@sifnoc
Copy link
Member

sifnoc commented Oct 31, 2022 •
edited

There is an error when sending an L2 tx by a user with more than 4 notes.
May TxBuilder prevent this error by limiting notes on the spending

We should handle this issue togateher zkopru-network/wallet#13

And this zkopru-network/wallet#30 quite related this one.

@KimiWu123 KimiWu123 self-assigned this Nov 7, 2022
@KimiWu123 KimiWu123 changed the title Zkopru - refine TxBuilder.build() and add more test cases [13pt] Zkopru - refine TxBuilder.build() and add more test cases Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KimiWu123 KimiWu123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sifnoc @KimiWu123