Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronizer error handling #363

Open
vimwitch opened this issue Jan 17, 2022 · 1 comment
Open

Synchronizer error handling #363

vimwitch opened this issue Jan 17, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@vimwitch
Copy link
Member

When there is a connection when retrieving blocks it doesn't restart. This forces the user to restart the browser window to get the synchronizer to continue downloading blocks.

@vimwitch
Copy link
Member Author

The synchronizer makes lots of calls to a web3 node that can potentially error, like here and here. These calls should be protected by some try/catch/retry logic to make sure that synchronization continues if there is a brief disruption to the connection.

There's also lots of repeated logic in the synchronizer around loading events from the past, this can probably be refactored at the same time.

@vimwitch vimwitch added the good first issue Good for newcomers label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant