Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add individual user overrides to the DKIM Registry contract #195

Open
Divide-By-0 opened this issue May 16, 2024 · 0 comments · May be fixed by #199
Open

Add individual user overrides to the DKIM Registry contract #195

Divide-By-0 opened this issue May 16, 2024 · 0 comments · May be fixed by #199
Assignees
Labels
enhancement New feature or request high

Comments

@Divide-By-0
Copy link
Member

One way for users to remove their dependence on the public key registry would be to only allow future keys to change once they have approved that. Spec changes:

  • add the current block timestamp to the set functions to the dkim key registry contract
  • add the userOverrideEnabled mapping of user -> timestamp, and userOverrideKeys mapping of (user, domain) -> key
  • add the user's account id (i.e. salted + hashed email) as a parameter on get queries for the registry contract
    • if the userOverrideEnabled mapping contains that user, then only return the key value if 1) the timestamp on the field it queries is before the user's set timestamp or 2) if the timestamp is after, then return the userOverrideKeys value of (user, domain) -> key
  • have a function that lets that user's account id change their approval public key via an ether-email-auth proof
  • add a function to update userOverrideKeys mapping that lets some EOA update the value of that key to a different value
  • add a function for updateApprovalTimestamp that lets the user change the timestamp on userOverrideEnabled to the current timestamp
@Divide-By-0 Divide-By-0 changed the title Add individual user overrides to the DKIM Registry Add individual user overrides to the DKIM Registry contract May 16, 2024
@Divide-By-0 Divide-By-0 added enhancement New feature or request high labels May 16, 2024
@Divide-By-0 Divide-By-0 linked a pull request May 28, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants