Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep arguments passed from user immutable #606

Open
sonalgoyal opened this issue Jun 9, 2023 · 0 comments
Open

keep arguments passed from user immutable #606

sonalgoyal opened this issue Jun 9, 2023 · 0 comments
Assignees

Comments

@sonalgoyal
Copy link
Member

We add the dataframe to the pipe when we read it, which modifies the original args object. In a way that is ok as we are only enriching the args. But the current design of args can lead to updating it downstream, which can lead to inadvertent issues.

Design args to be immutable.

@sonalgoyal sonalgoyal self-assigned this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant