Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI implementation #351

Open
Eriner opened this issue Dec 23, 2019 · 2 comments
Open

CI implementation #351

Eriner opened this issue Dec 23, 2019 · 2 comments
Assignees

Comments

@Eriner
Copy link
Member

Eriner commented Dec 23, 2019

It would be nice to have a CI system to perform both static (think shellcheck, grep-based style linting) and dynamic analysis (run in subshell, check retcode, prompt, function availability/functionality, etc).

Github Actions can be used for the CI. Necessary tooling is still unknown, as it would likely need to be zsh-specific and I'm not aware of any off the top of my head, though I haven't investigated what's available.

One obvious upside to performing testing like this is that we could test varying versions of zsh and catch any is-at-least type bugs, as well as PRs that may subtly break some functionality.

@Eriner Eriner self-assigned this Dec 23, 2019
@Eriner
Copy link
Member Author

Eriner commented Jan 11, 2020

koalaman/shellcheck#809

@grzesuav
Copy link

hi @Eriner , I could help with this by implementing as github actions. The are limited as to image you can use (it is not gitlab-ci) but shellcheck should be no problem.

I noticed that you stared to follow semantic releasing, maybe this is something which also could be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants