-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: indication of editing mode #115
Comments
@Valinora looks good! Perhaps for the eriner prompt, keep it on one line, but "flip" the arrow arround (or make it hollow), see the
.. and do a flip, |
With this theme, in longer directories the prompt is in the middle of the terminal, and get get pretty ugly in low resolution/small terminals with tiling WMs. That's why it's only a fork, and not a PR, because it has those customizations. I'll make a branch with and try to get a few prompts working with more thematic indicators for each prompt. |
I use the 'Lean' prompt, but since that's external, a fork would probably required. I'd be perfectly willing to switch, but not to a two-line prompt, since in my usage vertical space is always lacking. I'm not sure how easy it will be to tell which mode is currently active at a glance in your solution, though. Maybe just add 'Insert' text to the end of the prompt line to mimic Vim behavior? Since many prompts don't modify the end of the line, it might be easier to hack into prompts, although I know little about that. |
In mine, the arrow becomes red and faces the other direction when you're in 'NORMAL' mode. For the non-external themes I was planning on using a similar approach in a theme appropriate manor, however using a right hand side '[normal]' indicator should be pretty straightforward to implement. |
These are my initial ideas: Imgur Album |
The second screenshot looks perfect. The only nitpick is that it should be styled like '-- INSERT --', like in Vim, but that's of virtually no importance c: You probably can make the style used configurable through '.zimrc'. Some people put Git info, the clock or some other data there. I always thought it looks ugly when it inevitably overflows, but it's a matter of taste, I guess. |
It's easy to get to the following result, which I think would looker nicer than anything else (last line is in vicmd mode, with all separators inverted): Just replace As per #130, what we might need is a module for edit mode theming, as changing each prompt separately would create too much repeated code. |
While not related to Zim per se, it's possible to make vi mode visible with powerlevel9k and this in
|
@ericbn Does it make sense to keep this as a feature request on the main repo when it sounds like it needs to implemented per theme anyway? |
This could be done as a separate module, like Prezto did, but on the other hand, setting the module in each theme seems to add as much code as if it the changes were done directly. Should we add the vicmd mode indicator to all our themes? |
As in, normal/insert. Prezto had it. This link has some info on it, although I don't know enough about ZSH to do it myself.
The text was updated successfully, but these errors were encountered: