correctly handle non-existing username during permission testing

zikula · Sep 18, 2021 · 1adc96e · 1adc96e
1 parent 38715a0
commit 1adc96e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/system/PermissionsModule/Controller/PermissionController.php b/src/system/PermissionsModule/Controller/PermissionController.php
@@ -206,7 +206,7 @@ public function test(
         $result = $this->trans('Permission check result:') . ' ';
         if (!empty($data['user'])) {
             $user = $userRepository->findOneBy(['uname' => $data['user']]);
-            $uid = isset($user) ? $user->getUid() : Constant::USER_ID_ANONYMOUS;
+            $uid = isset($user) ? $user->getUid() : false;
         } else {
             $uid = Constant::USER_ID_ANONYMOUS;
         }
@@ -217,7 +217,7 @@ public function test(
             $granted = $this->hasPermission($data['component'], $data['instance'], $data['level'], $uid);
 
             $result .= '<span class="' . ($granted ? 'text-success' : 'text-danger') . '">';
-            $result .= (0 === $uid) ? $this->trans('unregistered user') : $data['user'];
+            $result .= Constant::USER_ID_ANONYMOUS < $uid && isset($user) ? $user->getUname() : $this->trans('unregistered user');
             $result .= ': ';
             if ($granted) {
                 $result .= $this->trans('permission granted.');