Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue in the program #285

Open
DLPerf opened this issue Aug 18, 2021 · 1 comment
Open

Performance issue in the program #285

DLPerf opened this issue Aug 18, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 18, 2021

Hello, I found a performance issue in the definition of cache_fn, train.py, tf.zeros will created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop in cache_fn.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
@DLPerf
Copy link
Author

DLPerf commented Sep 3, 2021

@zihangdai Hi, bro, could you consider the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DLPerf