Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safely read userAgent #18

Open
wangcheng opened this issue Mar 24, 2019 · 0 comments
Open

Safely read userAgent #18

wangcheng opened this issue Mar 24, 2019 · 0 comments
Assignees
@wangcheng
Labels
enhancement✨ New feature or request
Projects
SSR support

Comments

@wangcheng
Copy link
Contributor

wangcheng commented Mar 24, 2019 •
edited

  • Allow server side to pass userAgent string as a prop
  • remove directly reading of navigator.userAgent
@wangcheng wangcheng added the enhancement✨ New feature or request label Mar 24, 2019
@wangcheng wangcheng self-assigned this Mar 24, 2019
@wangcheng wangcheng added this to To do in SSR support via automation Mar 24, 2019
@wangcheng wangcheng changed the title Safely read UserAgent Safely read userAgent Mar 24, 2019
ambar added a commit to ambar/griffith that referenced this issue Jan 29, 2022
@ambar
fix: add isIE in ua
98323c5 
zhihu#18 zhihu#158
ambar added a commit to ambar/griffith that referenced this issue Jan 29, 2022
@ambar
fix: add isIE in ua
0bb4463 
zhihu#18 zhihu#158
@ambar ambar mentioned this issue Jan 29, 2022
Merged
ambar added a commit that referenced this issue Jan 29, 2022
@ambar
fix: add isIE in ua
d7a6924 
#18 #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangcheng wangcheng

Labels
enhancement✨ New feature or request
Projects
SSR support
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wangcheng