Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic dependency #564

Open
andresailer opened this issue May 3, 2024 · 6 comments
Open

Pydantic dependency #564

andresailer opened this issue May 3, 2024 · 6 comments

Comments

@andresailer
Copy link

Hi @jonas-eschle

Is the requirement for pydantic something for the runtime of zfit

pydantic<2.0.0 # fails with not a "subclass", won't fix soon

Or is this a testing dependency?
For the LCGstacks it would be nice if we can update pydantic.

Thanks for clarifying!

@jonas-eschle
Copy link
Contributor

jonas-eschle commented May 3, 2024

Hey thanks for bringing it up, it's unfortunately a runtime dependency, but an inconvenient one! It is however only used in the serialization.
We're working on getting it upgraded or at least having it as an optional dependency, it's a blocker otherwise.
I'll ping you if there are updates

@andresailer
Copy link
Author

Thanks for your answer! I look forward to the update :)
We are currently trying to get python 3.11 integrated, and for that we need to update pydantic.

@jonas-eschle
Copy link
Contributor

We are currently trying to get python 3.11 integrated, and for that we need to update pydantic.

Out of curiosity, why exactly would you need that for Python 3.11? I assume some dependency conflicts? Pydantic 1 supports up to 3.12 at least

@andresailer
Copy link
Author

Ahh, good point! Maybe we just too eagerly updated from the version we had, and we should just go to https://pypi.org/project/pydantic/1.10.15/.

@jonas-eschle
Copy link
Contributor

jonas-eschle commented May 3, 2024

That should surely work as an intermediate step, yes

I'll keep this anyway open, as we're trying to move to Pydantic 2 anyways

thanks for upgrading the LCG!

@ikrommyd
Copy link
Contributor

@andresailer you will need pydantic 2 if you upgrade correctionlib to v2.5.0 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants