-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Plush compiler (cplush) deprecation #91
Comments
Is this about the parser written in C++ or the self hosting parser? |
The one written in C++ |
I may be wrong, but we should not have this problem on the self hosted version of Plush. |
That's why I was asking. The comments in the self hosted version indicate that these cases were explicitily handled. |
@Maaarcocr @krypt-n I just saw the code. Self hosted parser handles these cases but one written in c++ does not. |
My goal is to deprecate the C++ parser once the Plush package can fully compile itself. Very close to that, but missing some small key ingredients. You could backport fixes from |
@maximecb There is no point in backporting the changes if it is going to deprecate. We should rather put efforts in making plush parser as capable as cplush. Can we keep this issue open until plush can parse itself. |
Sure. I'll take the opportunity to tell you what the current state of this is:
|
Tagged this for the MVP milestone. Getting rid of the C++ parser is probably something that needs to get done soon-ish, before we promote Zeta more actively, because I think people find it generally confusing that there are two Plush implementations. |
Some of the language keywords require whitespace after them. E.g.
return 42;
should be valid butreturn42;
should be not. Currently Plush parser does not check for this. Allowing you to write code likeAlso it throws error when function name starts with any of the keywords like
throw
,return
,var
etc. Here in linethrowAwayTheArgument(12);
, Paser parses it asthrow AwayTheArgument(12);
causing an errorERROR: get_field failed, missing field "AwayTheArgument"
.The text was updated successfully, but these errors were encountered: