Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an error either to worker or client when message is too big to be dispatched #70

Open
aurelien-baudet opened this issue Jul 5, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@aurelien-baudet
Copy link
Contributor

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request

Scope (check one with "x")

[ ] @zetapush/cli
[X] @zetapush/cometd
[ ] @zetapush/core
[ ] @zetapush/create
[ ] @zetapush/platform
[X] @zetapush/worker

Current behavior

When a response generated by a worker is too big, a log is displayed indicating that the worker has finished the processing and returned the result but the client never receives it.

Expected behavior

If the response is too big, either an error message should be received by the client or the worker should fail and should be able to catch the error to handle it.

Minimal reproduction of the problem with instructions

  1. Create a new project
  2. In the worker code, do a loop to generate a string with 1000000 concatenated 'hello'
  3. Run both worker and client
  4. Client calls the worker
    => no answer and no error at all

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Operating System:
  • Node Version: any
  • Npm Version: any
  • @angular/* Version: any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants