Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add 2FA handling in zmq/ssh/tunnel.py #1127

Open
dmanikowski-reef opened this issue Jan 8, 2018 · 2 comments
Open

[ENH] Add 2FA handling in zmq/ssh/tunnel.py #1127

dmanikowski-reef opened this issue Jan 8, 2018 · 2 comments

Comments

@dmanikowski-reef
Copy link

Hi guys,
I was investigating this issue from IPython regarding 2-factor authentication:
ipython/ipython#10934
and finally reached the pyzmq code.
My guess is that https://github.com/zeromq/pyzmq/blob/master/zmq/ssh/tunnel.py file is the best place to implement this feature.

As soon as you confirm that I'm right, I'll try to implement this :)

@minrk
Copy link
Member

minrk commented Jan 8, 2018

That sounds right! It's fine to do it here, but it could also be appropriate to take this opportunity to fork the implementation into jupyter_client itself, which gets releases more often and uses this code more than most.

@dmanikowski-reef
Copy link
Author

Hm - so what's on your mind is that we should move the whole ssh tunneling straight to IPython?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants