Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with SQLAlchemy 2+ #106

Open
timmc opened this issue Apr 15, 2023 · 0 comments
Open

Broken with SQLAlchemy 2+ #106

timmc opened this issue Apr 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@timmc
Copy link
Contributor

timmc commented Apr 15, 2023

How did you install matrix-registration?

pip

What python version are you running?

3.9.2

What version of matrix-registration are you running?

v0.9.2.dev3

Your config.yml

No response

Your error log

Traceback (most recent call last):
  File "/srv/commdata/matrix/regui/venv/bin/matrix-registration", line 5, in <module>
    from matrix_registration.app import cli
  File "/srv/commdata/matrix/regui/venv_py3.9.2/lib/python3.9/site-packages/matrix_registration/__init__.py", line 1, in <module>
    from . import api
  File "/srv/commdata/matrix/regui/venv_py3.9.2/lib/python3.9/site-packages/matrix_registration/api.py", line 24, in <module>
    from . import tokens
  File "/srv/commdata/matrix/regui/venv_py3.9.2/lib/python3.9/site-packages/matrix_registration/tokens.py", line 25, in <module>
    db = SQLAlchemy()
  File "/srv/commdata/matrix/regui/venv_py3.9.2/lib/python3.9/site-packages/flask_sqlalchemy/__init__.py", line 758, in __init__
    _include_sqlalchemy(self, query_class)
  File "/srv/commdata/matrix/regui/venv_py3.9.2/lib/python3.9/site-packages/flask_sqlalchemy/__init__.py", line 112, in _include_sqlalchemy
    for key in module.__all__:
AttributeError: module 'sqlalchemy' has no attribute '__all__'

Area of your issue?

general usage

What happened

The setup.py file only has a min-version constraint on sqlalchemy and various other packages, but installation has recently started failing since sqlalchemy has released a 2.x version that presumably contains a breaking change.

In master...timmc:matrix-registration:timmc/pin-reqs I demonstrate an alternative approach that allows constraints to be kept as they currently are, but pins the constraint-solver's solution. This approach allows for controlled upgrades.

Steps to reproduce

No response

@timmc timmc added the bug Something isn't working label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant