You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your enhancement proposal related to a problem? Please describe.
A lot of the Kconfig options in LE Audio use select rather than depends on to handle dependencies. This was originally done to make 3rd party GUIs like menuconfig work better (as it hides Kconfig options that does not have it dependencies enabled), but 3rd party tools should not decide how we best configure Zephyr. This also better follows the best practices for Kconfig as per https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-pitfalls and why select should not be used that much.
Describe the solution you'd like
Replace select X with depends on X for all Kconfig options where it's possible. There may be exceptions where select is still needed, such as enabling promptless options like config BT_BAP_UNICAST.
In those cases, we should replace the select <promptless> with def_bool so that
configBT_BAP_UNICASTbooldependsonBT_CONNselectBT_SMPselectBT_ISO_UNICASTconfigBT_BAP_UNICAST_SERVERbool"Bluetooth Unicast Audio Server Support"selectBT_BAP_UNICASTselectBT_GATT_DYNAMIC_DBselectBT_GATT_CACHINGdependsonBT_PERIPHERALdependsonBT_ISO_PERIPHERALdependsonBT_ASCSdependsonBT_PACShelpThisoptionenablessupportforBluetoothUnicastAudioServerusingIsochronouschannels.
becomes
config BT_BAP_UNICAST
def_bool BT_BAP_UNICAST_SERVER
config BT_BAP_UNICAST_SERVER
bool "Bluetooth Unicast Audio Server Support"
depends on BT_GATT_DYNAMIC_DB
depends on BT_GATT_CACHING
depends on BT_SMP
depends on BT_PERIPHERAL
depends on BT_PERIPHERAL
depends on BT_ISO_PERIPHERAL
depends on BT_ASCS
depends on BT_PACS
help
This option enables support for Bluetooth Unicast Audio Server
using Isochronous channels.
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Is your enhancement proposal related to a problem? Please describe.
A lot of the Kconfig options in LE Audio use
select
rather thandepends on
to handle dependencies. This was originally done to make 3rd party GUIs like menuconfig work better (as it hides Kconfig options that does not have it dependencies enabled), but 3rd party tools should not decide how we best configure Zephyr. This also better follows the best practices for Kconfig as per https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-pitfalls and whyselect
should not be used that much.Describe the solution you'd like
Replace
select X
withdepends on X
for all Kconfig options where it's possible. There may be exceptions whereselect
is still needed, such as enabling promptless options likeconfig BT_BAP_UNICAST
.In those cases, we should replace the
select <promptless>
withdef_bool
so thatbecomes
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: