Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dark mode script does not remove theme switcher #112

Closed
1 task done
Frank3K opened this issue Mar 29, 2024 · 2 comments
Closed
1 task done

Remove dark mode script does not remove theme switcher #112

Frank3K opened this issue Mar 29, 2024 · 2 comments

Comments

@Frank3K
Copy link

Frank3K commented Mar 29, 2024

What is your Hugo Extended Version

hugo v0.124.1-db083b05f16c945fec04f745f0ca8640560cf1ec+extended

What is your Go Version

go version go1.22.1

What is your Node.js Version

v20.2.0

Check for Existing Issues

  • I have searched and found no relevant issues.

Expected Behavior

When running the remove-darkmode script, the theme switcher is not removed.

Steps to Reproduce

  1. Install the theme according to the instructions in the README.
  2. Run yarn run remove-darkmode.
  3. Build the site.
  4. Observe that the theme switcher (which enables the user to toggle between light and dark modes) is still present.

Code Reproduction URL

No response

Additional Information

The following things should be removed:

  1. The SCSS for the theme-switcher (src).
  2. The theme-switcher HTML (src).
  3. The use of the partial in the header (src).
  4. The darkmode logo (src).
  5. The darkmode logo reference in params.toml (src).
  6. Theme switcher config in params.toml (src).
tfsomrat added a commit that referenced this issue May 16, 2024
@tfsomrat
Copy link
Contributor

Hey @Frank3K, thanks for creating this issue. we updated the script. now it will work perfectly.

@Frank3K
Copy link
Author

Frank3K commented May 16, 2024

Thanks for fixing, appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants