Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_probe_feed warnings about missing "queries" key #38

Open
zbuc opened this issue Jun 2, 2017 · 1 comment
Open

add_probe_feed warnings about missing "queries" key #38

zbuc opened this issue Jun 2, 2017 · 1 comment

Comments

@zbuc
Copy link

zbuc commented Jun 2, 2017

When importing feeds, I see warnings about the "queries" key not being present.

The key is present, however, and this doesn't seem to present an issue -- all the feeds are imported as expected.

This can be replicated against one of the example feeds:

zentral@1ed956dcdc6a:/zentral$ python server/manage.py add_probe_feed https://raw.githubusercontent.com/zentralopensource/zentral-feeds/master/demo/osquery.json
2017-06-02 19:10:26,627 PID343 feeds WARNING Feed serializer <class 'zentral.contrib.osquery.feeds.PackSerializer'> errors
2017-06-02 19:10:26,628 PID343 feeds WARNING {'queries': ['This field is required.']}
2017-06-02 19:10:26,786 PID343 feeds WARNING Feed serializer <class 'zentral.contrib.osquery.feeds.PackSerializer'> errors
2017-06-02 19:10:26,786 PID343 feeds WARNING {'queries': ['This field is required.']}
Feed https://raw.githubusercontent.com/zentralopensource/zentral-feeds/master/demo/osquery.json synced.
Probes created: 6.
@np5
Copy link
Collaborator

np5 commented Jun 3, 2017

When we import a feed, we try 2 different serializer classes. We first try to read it as an osquery pack, and then, because it doesn't work, as a zentral feed. The warnings show that the feed is not a valid osquery pack. We should maybe not display them (we don't show them in the web interface).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants