Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very minor: customers_info_date_account_created should be date_account_created in Customer.php #6444

Closed
neekfenwick opened this issue May 10, 2024 · 1 comment · Fixed by #6447

Comments

@neekfenwick
Copy link
Contributor

Very minor issue, I noticed the field name is wrong in Customer.php. I'm not sure if this has any actual impact on the system.

if (empty($this->data['customers_info_date_account_created'])) {
$sql = "INSERT IGNORE INTO " . TABLE_CUSTOMERS_INFO . " (customers_info_id) VALUES (:customersID)";
$sql = $db->bindVars($sql, ':customersID', $customer_id, 'integer');
$db->Execute($sql);

While the database field is indeed customers_info_date_account_created, the data element being referenced here is date_account_created. The result is that the if always tests true, so the INSERT IGNORE is always attempted.

Anyone making mods to Customer.php might want to include this little fix.

@scottcwilson
Copy link
Sponsor Contributor

thanks, please PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants