Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order ip addresses and lookups #6333

Closed
torvista opened this issue Mar 19, 2024 · 2 comments · Fixed by #6455
Closed

order ip addresses and lookups #6333

torvista opened this issue Mar 19, 2024 · 2 comments · Fixed by #6455

Comments

@torvista
Copy link
Member

For an order, the session and server ip are stored together:

'ip_address' => $_SESSION['customers_ip_address'] . ' - ' . $_SERVER['REMOTE_ADDR'],

and output together

image

I assume this is because there is a possibility they may be different?

So should not the hyperlinks for these be separately generated? At the moment there is one around both.

@drbyte
Copy link
Member

drbyte commented Mar 19, 2024

They can occasionally be different, such as (sometimes) if the payment provider does a redirect from another website, or the payment is recorded via a webhook such as a PayPal IPN handler (and other providers that hit a handler/webhook endpoint).

I suppose the link could be split to two different ones in the Admin.

drbyte added a commit to drbyte/zencart that referenced this issue May 15, 2024
If 2 IPs are listed, both are turned into clickable whois links.

Fixes zencart#6333
drbyte added a commit to drbyte/zencart that referenced this issue May 15, 2024
If 2 IPs are listed, both are turned into clickable whois links.

Fixes zencart#6333
@drbyte drbyte linked a pull request May 15, 2024 that will close this issue
@scottcwilson
Copy link
Sponsor Contributor

Closed by #6455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants