Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product, add to cart form tags #6204

Open
torvista opened this issue Feb 3, 2024 · 0 comments
Open

product, add to cart form tags #6204

torvista opened this issue Feb 3, 2024 · 0 comments

Comments

@torvista
Copy link
Member

torvista commented Feb 3, 2024

  1. The enclosing tags for the form seem far wider than necessary/very detached from the form fields.
    The start tag is right after the breadcrumb, encompassing the category image, prev-next, product name, Ask a Question.
    The end tag is...at the end, including description, reviews, Also Purchased.

Doesn't seem right and not an error, but to add another form like Back in Stock/to put AAQ on the same page/merge the two, requires moving that closing tag up to where it actually should be.
Why not put the form tags only around the input elements?

  1. The form id "AddToCartForm" and name "cart_quantity" are not the same.
    Not a bug either, but it seems convention is to keep them the same.

While logically AddtoCartForm would be the better one to use, it is not used anywhere and so easy to replace, unlike cart_quantity which would cause much wailing and gnashing of teeth with plugin authors if touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant