Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R/O Option Type: Ignore for Add to Cart confusion #5959

Open
lat9 opened this issue Aug 26, 2023 · 1 comment
Open

R/O Option Type: Ignore for Add to Cart confusion #5959

lat9 opened this issue Aug 26, 2023 · 1 comment

Comments

@lat9
Copy link
Contributor

lat9 commented Aug 26, 2023

As described in this EO issue, I'm finding the operation of the subject configuration setting (PRODUCTS_OPTIONS_TYPE_READONLY_IGNORED , in Configuration :: Attribute Settings) quite confusing. I'm thinking that it's a combination of the setting's configuration_key name as well as its description:
image

The behavior that I'm seeing on the storefront is as follows:

  • When the setting is '0'
    • A product with only a read-only attribute, e.g. the demo products' main_page=product_free_shipping_info&cPath=64&products_id=172, cannot be directly added to the cart from listing pages.
    • When the product is added to the cart, the R/O attribute is not displayed and the attribute is not recorded in the order.
  • When the setting is '1'
    • A product with only a R/O attribute can be directly added to the cart from listing pages.
    • The attribute is displayed when the product is added to the cart and is recorded along with the product in the order.

Although it 'feels' bass-ackwords, it appears that to correct the referenced EO issue, R/O attributes are to be included in an order when PRODUCTS_OPTIONS_TYPE_READONLY_IGNORED is '1' and not when the value is '0'.

While I'm not advocating that the name of the configuration setting be changed, I do believe that its configuration description should be modified to identify what-the-heck it's really doing.

@scottcwilson
Copy link
Sponsor Contributor

The documentation cupboard is a bit bare too in this area. If you want to write something long form I'd be happy to add it to https://docs.zen-cart.com/user/products/attributes_info/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants