Sync product-info templates?

[lat9]

As this feature is going into Bootstrap v3.7.0 (lat9/ZCA-Bootstrap-Template#364), what's the feeling for combining the tpl_{product-type-page}_display.php files in the base Zen Cart?

Other than some base HTML id or class differences, they're all pretty much the same. Granted, product_music_info is an outlier which is why I've broken out the display of a product's "details" as a separately customizable element as well as having an optional additional information block.

[simon1066]

Personally, I make significant use of the different product types (exc. product free shipping) and have made a varying number of modifications to said template files. There may be other ways to achieve those changes but using separate template files was pretty straightforward.

[lat9]

Those changes don't prohibit heavy-customization of the different product types' information pages, but they do make it easier to simply reuse tpl_product_info_display.php which cuts down on the base offering changes-required when a new feature (think ask-a-question) is introduced.

[drbyte]

I'm agreeable to it.

Are you thinking 3.0? Or 2.1 ?

[lat9]

2.1

[drbyte]

I haven't fully analyzed what you did in the Bootstrap template for this.
I know that "document_general" excludes a whole lot of things that the others "include". I guess if the core it's inheriting from just organically skips anything that has no data available for it, then it may be fine. What about when one intentionally wants something "blank" but not "skipped"?

[lat9]

As mentioned to @simon1066, sites have the ability to fully control any template rendering by just not pulling in tpl_product_info_display.php.

I did file-compares (at least on Bootstrap) and (other than good ol' product_music) the only differences in processing was what prefix was applied to various divs' id= attributes. The templates just 'honor' the settings provided by their page's header_php.php and main_template_vars.php.

[drbyte]

Right. The modularity does make it much simpler.