Image size definitions and where used

[torvista]

As I was confused, and the Docs are needing input
https://docs.zen-cart.com/user/images/image_configuration/
I reviewed the constants and their uses.
Results:
https://docs.google.com/spreadsheets/d/1GNSe8Bk5QGeNhLZ4yMqO6Vl-xtyv9wO3auY_uPZRb80/edit?usp=sharing

[lat9]

Nice one, @torvista! Thanks for the details analysis.

[torvista]

One could discuss about separating admin image control from storefront, and removing the unused constants.

[scottcwilson]

I would be eternally grateful (well, to the end of the week at least) if you would resolve the FIXME in this doc page. :)

[torvista]

Nothing in there to be fixed first....?

[scottcwilson]

When I say "resolve" I mean "resolve by fixing what's wrong" (not just removing the FIXME line). :)

[torvista]

I meant fixing what's wrong with the image definitions: a pair are not used or should be...

[scottcwilson]

• Unused constants - remove from install script, other files is sufficient for now.
• Documentation - update as needed to correct.

Please don't pursue "separating admin image control from storefront."

[torvista]

As removing constants is a db change, the references in the new install can go now, but the removal from existing sites needs to wait until a next version when there's an upgrade script.

[drbyte]

No constants to be removed anymore. They were temporarily missing in v1.5.8, but are restored in v2.0.0.
#6251