Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include quoted tweet body in RSS #132

Open
gloschtla opened this issue Mar 4, 2020 · 7 comments · May be fixed by #820
Open

Include quoted tweet body in RSS #132

gloschtla opened this issue Mar 4, 2020 · 7 comments · May be fixed by #820
Labels
enhancement New feature or request rss RSS-related issues

Comments

@gloschtla
Copy link

In nitter's RSS feed the tweet content appears in the Feed entry title. This also is the case with RT: retweets. If a tweet of a news channel or blog is retweetet without adding a comment, the content of the original tweet appears in the RSS feed of the retweeter. OK, but this is not the case, if an own comment was added for the retweet.

Feature request: Would you please append the original tweet to the comment of the retweeter? Reason: This would bring the posted URL into the title of the RSS feed of the retweeting account.

@zedeus
Copy link
Owner

zedeus commented Mar 4, 2020

You seem to be asking for two things here, the URL and the content of the tweet. I'm assuming you mean quote tweets, like this one: https://nitter.net/elonmusk/status/1225608700477440000#m
What would you expect to see here?

@gloschtla
Copy link
Author

gloschtla commented Mar 5, 2020

OK, in your case we have a double-retweet, each with an own comment: Elon shared Gaelic's tweet, who had shared Victor's tweet. Since Victor's original tweet contains no posted URL, but only a picture, the tweet-URL of Victor should be appended to Elon's comment - in Elon's RSS Feed entry title! example: "SpaceX blabla .. + https://nitter.net/victor_dls/status/1225598450475114496#m"

But now I wanna give an example for the case, I was thinking of: The original tweet tells news by using an external link as a reference. Then this original tweet is retweeted with a comment by another twitter user. Example: https://nitter.net/theblogcat/status/1234159395124236290

So, this is what above Blogger's RSS feed title should contain: " Das kriminelle... blabla + https://www.gouvernement.fr/en/how-government-works "

This enables us, to import twitter RSS feeds into the timeline of other social networks, where the original referencing URL is used to load the link preview in the target timeline, making it more appealing for the viewers.

@zedeus
Copy link
Owner

zedeus commented Mar 6, 2020

The tweet you linked by theblogcat is not a retweet, it's a quote. I don't think it's a good idea to embed the quoted tweet's text since the text-only ux for this is.. not good. I can't even think of a good way to represent it. Here's one option:

Das kriminelle Macron-Regime will die Rentenreform durch die Hintertür (unter Umgehung des Parlaments) einführen.

Quote from Ollie Richardson (@O_Rich_):
>THREAD on what the criminal @EmmanuelMacron regime is trying to do, trying to push pension reform through the backdoor.

>Firstly, read this, especially about Article 49.3:
>gouvernement.fr/en/how-gover…

But, it isn't clear that this is an embedded quote, it could just be how the user wrote the tweet. Alternatively it could just include a link to the tweet (I think this is done already but not sure, I don't use the rss feature)

@McPwned
Copy link

McPwned commented Apr 12, 2020

I started using the RSS feed feature yesterday and I would also like quoted tweets to be embedded. For an example of the present situation, this tweet appears like so on the RSS feed. Could we have the content of the quote "1/ Here's one for [...]" appear instead of only a link? I'd rather avoid having to open the quoted tweet just to get context if possible.

As for how it might be formatted, would a separating line work? Something like:

uhhh wow a proprietary online home is a new low
##### Quote from Jon Frisby (@MrJoy) #####
1/ Here's one for @internetofshit:  I just bought a brand new home, built by @DRHorton. One of the selling points is that it has "Smart Home Technology." I was explicitly told that I would own the devices and I don't need to sign up for @ADT service.
##### End quote #####
nitter.net/MrJoy/status/1246870277784350720#m

@zedeus zedeus changed the title Include original posting-URL into commenting-retweets - feature request Include quoted tweet body in RSS Jan 3, 2022
@zedeus zedeus added enhancement New feature or request rss RSS-related issues labels Jan 3, 2022
@gil
Copy link

gil commented Mar 28, 2023

Hey @zedeus ! I'm also interested in this, so I tried to hack the template a bit with:

diff --git a/src/views/rss.nimf b/src/views/rss.nimf
index 96f6466..5007801 100644
--- a/src/views/rss.nimf
+++ b/src/views/rss.nimf
@@ -33,10 +33,6 @@ Twitter feed for: ${desc}. Generated by ${cfg.hostname}
 #let urlPrefix = getUrlPrefix(cfg)
 #let text = replaceUrls(tweet.text, defaultPrefs, absolute=urlPrefix)
 <p>${text.replace("\n", "<br>\n")}</p>
-#if tweet.quote.isSome and get(tweet.quote).available:
-#  let quoteLink = getLink(get(tweet.quote))
-<p><a href="${urlPrefix}${quoteLink}">${cfg.hostname}${quoteLink}</a></p>
-#end if
 #if tweet.photos.len > 0:
 #  for photo in tweet.photos:
 <img src="${urlPrefix}${getPicUrl(photo)}" style="max-width:250px;" />
@@ -54,6 +50,12 @@ Twitter feed for: ${desc}. Generated by ${cfg.hostname}
 <img src="${urlPrefix}${getPicUrl(card.image)}" style="max-width:250px;" />
 #  end if
 #end if
+#if tweet.quote.isSome and get(tweet.quote).available:
+#  let quoteLink = getLink(get(tweet.quote))
+<hr/>
+<p>Quoting: <a href="${urlPrefix}${quoteLink}">${cfg.hostname}${quoteLink}</a></p>
+${renderRssTweet(get(tweet.quote), cfg)}
+#end if
 #end proc
 #
 #proc renderRssTweets(tweets: seq[Tweet]; cfg: Config): string =

Would you be interested in a pull request? I don't have any experience with this codebase or Nim, so sorry if I did something wrong, but it seem simple enough and gives me good results so far.

@gil gil linked a pull request Mar 29, 2023 that will close this issue
@untitaker
Copy link

I am also interested in this landing, it would make reading tweets in my RSS reader a lot easier.

@koszzz
Copy link

koszzz commented Sep 2, 2023

I need it, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rss RSS-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants