Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: zinit update does not pull stable release from GitHub releases #606

Open
1 task done
hrai opened this issue Dec 14, 2023 · 3 comments
Open
1 task done

[bug]: zinit update does not pull stable release from GitHub releases #606

hrai opened this issue Dec 14, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@hrai
Copy link

hrai commented Dec 14, 2023

What happened?

zinit from'gh-r' sbin'**/nvim' ver'stable' for neovim/neovim

My neovim version is below

NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

When I run zinit update neovim/neovim it doesn't pull the latest release which is v0.9.4
image

Instead it shows below:
image

Steps to reproduce

Add zinit from'gh-r' sbin'**/nvim' ver'stable' for neovim/neovim
Run zinit update neovim/neovim

Relevant output

No response

Screenshots and recordings

No response

Operating System & Version

OS: linux-gnu | Vendor: ubuntu | Machine: x86_64 | CPU: x86_64 | Processor: x86_64 | Hardware: x86_64

Zsh version

zsh 5.9 (x86_64-ubuntu-linux-gnu)

Terminal emulator

Windows Terminal - xterm-256color

If using WSL on Windows, which version of WSL

WSL 2

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hrai hrai added the bug Something isn't working label Dec 14, 2023
@vladdoster
Copy link
Member

@hrai,

Interesting... I think this is what is happening.

It is checking for stable, but because stable is a word and not a number, it concludes that it is already up to date.

@vladdoster
Copy link
Member

vladdoster commented Dec 31, 2023

@hrai,

I've been aware of this bug for a while and think your issue will be fixed by addressing update option parsing and now seems like a good time to squash this bug.


Currently, to re-download the stable version (or something like nightly), the flags break it and force the following process:

(){
  setopt local_options interactive_comments
  # Note: both flags are required.... this is the bug :^)
  zinit update \
    --reset \
    --urge \
    neovim/neovim
  # Next, run:
  zinit update \
    --reset \
    neovim/neovim
}
Screenshot 2023-12-31 at 15 01 46

So I think the fix is fixing flag parsing. Stay tuned!

@hrai
Copy link
Author

hrai commented May 15, 2024

@vladdoster any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants