Help: tmux binary with bin-gem-node #391

albertfgu · 2022-10-02T21:30:42Z

albertfgu
Oct 2, 2022

I recently updated all my plugins to use bin-gem-node for the convenient shims. However, I'm having a lot of different issues with tmux.

The original line was

zinit ice from"gh-r" as"program" mv"tmux* -> tmux"
zinit load tmux/tmux

This still works fine. However, it seems like it's recommended to move to an updated syntax that uses the for syntax and sbin to create shims. For example, most of my other plugins now use the syntax

zinit for \
    from'gh-r' \
    as'null' \
    sbin'**/nvim -> nvim' \
  neovim/neovim

With tmux, I've tried all sorts of combinations like this and they always fail. For example, I tried modifying the original command with all variations of as and sbin, e.g.

zinit ice from"gh-r" as"null" sbin"**/tmux* -> tmux"
zinit load tmux/tmux

and they all give some form of error.

In the Recipes for popular programs Wiki, the command they give is

zinit for \
    as'null' \
    atclone'./configure --disable-utf8proc --prefix=$PWD' \
    atpull'%atclone' \
    extract'!' \
    from'gh-r' \
    id-as'tmux' \
    make'PREFIX=$PWD install'\
    nocompile \
    sbin \
    ver'latest' \
  @tmux/tmux

However, this immediately runs into an error with not finding the right version. Deleting the ver'latest' line fixes this. However then it compiles tmux from scratch, and I don't see the point of this over just grabbing the binary.

Question 1: What's the point of the complicated tmux recipe? Is there any advantage of compiling from scratch?
Question 2: What's the simplest way to get the tmux binary from GH-release with the bgn shim?

Answered by vladdoster

Nov 6, 2022

@albertfgu, We recently added a configure ice, so this works:

zinit for \
    as'null' \
    configure'--disable-utf8proc --prefix=$PWD --quiet' \
    make'PREFIX=$PWD --quiet install'\
    sbin \
  @tmux/tmux

View full answer

vladdoster · 2022-10-29T20:42:58Z

vladdoster
Oct 29, 2022
Maintainer

Hi @albertfgu,

Those are good questions and I can provide answers since I have added all the recipes.

What's the point of the complicated TMUX recipe? Is there any advantage of compiling from scratch?

The recipe compiles Tmux because the binary provided does not support macOS. Additionally, compiling Tmux takes a relatively short time, so I chose to add a recipe that would work for more users. Finally, I couldn't find a repository with pre-compiled macOS binaries.

What's the simplest way to get the tmux binary from GH-release with the bgn shim?

Let me get back to you on this in a day or two.

0 replies

albertfgu · 2022-10-31T18:05:24Z

albertfgu
Oct 31, 2022
Author

I see, thanks! However, as mentioned in the original post I thought that the command

zinit ice from"gh-r" as"program" mv"tmux* -> tmux"
zinit load tmux/tmux

does actually still work and grab a correct binary on macOS. It just doesn't use the sbin shim, which I can't figure out how to do.

1 reply

vladdoster Nov 6, 2022
Maintainer

But the release asset does not contain a tmux binary?

vladdoster · 2022-11-06T16:41:57Z

vladdoster
Nov 6, 2022
Maintainer

@albertfgu, We recently added a configure ice, so this works:

zinit for \
    as'null' \
    configure'--disable-utf8proc --prefix=$PWD --quiet' \
    make'PREFIX=$PWD --quiet install'\
    sbin \
  @tmux/tmux

0 replies

vladdoster · 2022-11-20T06:10:33Z

vladdoster
Nov 20, 2022
Maintainer

@albertfgu Pinging

0 replies

albertfgu · 2022-11-29T00:21:01Z

albertfgu
Nov 29, 2022
Author

Thanks for the response and sorry for the delay in following up! On one of my computers, the new command works beautifully. Thanks a lot!

On my other computer however (macOS Monterey 12.6.1, it's still being set up but I'm not sure which programs if any are missing...), I'm running into an error:

Downloading tmux/tmux…
Cloning into '/Users/albertgu/.local/share/zinit/plugins/tmux---tmux'...
⠙ ███████████ OBJ: 100, PACK: 46770/46770, COMPR: 100%, REC: 100%, RES: 100%
Running ./autogen.sh…
configure.ac:45: installing 'etc/compile'
configure.ac:10: installing 'etc/config.guess'
configure.ac:10: installing 'etc/config.sub'
configure.ac:8: installing 'etc/install-sh'
configure.ac:8: installing 'etc/missing'
Makefile.am: installing 'etc/depcomp'
configure.ac: installing 'etc/ylwrap'
configure.ac:47: warning: The macro `AC_PROG_CC_C99' is obsolete.
configure.ac:47: You should run autoupdate.
./lib/autoconf/c.m4:1659: AC_PROG_CC_C99 is expanded from...
configure.ac:47: the top level
Running ./configure --prefix=/Users/albertgu/.local/share/zinit/polaris…
./configure: line 4970: PKG_PROG_PKG_CONFIG: command not found
./configure: line 6079: syntax error near unexpected token `newline'
./configure: line 6079: `PKG_CHECK_MODULES('
Warning: zinit-configure-hook hook returned with 2
ERROR: No Makefile nor meson build dir found, make/meson isn't run!

I also noticed that on this computer, which configure points to ~/.local/share/zinit/polaris/bin/configure whereas on the computer which works, which configure shows up empty. I'm not entirely sure what's going on. Thanks in advance!

0 replies

vladdoster · 2022-11-30T17:11:08Z

vladdoster
Nov 30, 2022
Maintainer

@albertfgu I think youre missing pkg-config.

Try running:

sudo xcode-select --install

It'll install or output the following:

ᐳ sudo xcode-select --install  
Password:
xcode-select: error: command line tools are already installed, use "Software Update" to install updates

If you get the above, if you use Homebrew, you can run:

brew install pkg-config

0 replies

albertfgu · 2022-11-30T18:52:34Z

albertfgu
Nov 30, 2022
Author

I followed that and also had to brew install libevent and everything works! Thanks so much for your help!!

0 replies

vladdoster · 2022-11-30T19:01:55Z

vladdoster
Nov 30, 2022
Maintainer

Glad it works for you now. Thanks for using Zinit!

0 replies

albertfgu · 2023-04-11T19:42:16Z

albertfgu
Apr 11, 2023
Author

I recently tried installing on a new Linux machine and ran into the following output:

Downloading tmux/tmux…
Cloning into '/home/user/.local/share/zinit/plugins/tmux---tmux'...
⠼ ███████████ OBJ: 100, PACK: 47007/47007, COMPR: 100%, REC: 100%, RES: 100%
Running ./autogen.sh…
configure.ac:45: installing 'etc/compile'
configure.ac:10: installing 'etc/config.guess'
configure.ac:10: installing 'etc/config.sub'
configure.ac:8: installing 'etc/install-sh'
configure.ac:8: installing 'etc/missing'
Makefile.am: installing 'etc/depcomp'
configure.ac: installing 'etc/ylwrap'
Running ./configure --prefix=/home/user/.local/share/zinit/polaris…
Running `make PREFIX=$PWD --quiet install`…
format.c: In function ‘format_find’:
format.c:3542:5: warning: format not a string literal, format string not checked [-Wformat-nonliteral]
 3542 |     strftime(s, sizeof s, time_format, &tm);
      |     ^~~~~~~~
format.c: In function ‘format_expand1’:
format.c:4720:3: warning: format not a string literal, format string not checked [-Wformat-nonliteral]
 4720 |   if (strftime(expanded, sizeof expanded, fmt, &es->tm) == 0) {
      |   ^~
hyperlinks.c: In function ‘hyperlinks_put’:
hyperlinks.c:160:34: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
  160 |  xasprintf(&external_id, "tmux%llX", hyperlinks_next_external_id++);
      |                               ~~~^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                  |                              |
      |                                  long long unsigned int         uint64_t {aka long unsigned int}
      |                               %lX
input.c: In function ‘input_reply_clipboard’:
input.c:2844:50: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
 2844 |   if ((outlen = b64_ntop(buf, len, out, outlen)) == -1) {
      |                                                  ^~
notify.c: In function ‘notify_add’:
notify.c:196:36: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘u_int’ {aka ‘unsigned int’} due to unsignedness of other operand [-Wsign-compare]
  196 |  ne->pane = (wp != NULL ? wp->id : -1);
      |                                    ^~
notify.c: In function ‘notify_hook’:
notify.c:243:51: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘u_int’ {aka ‘unsigned int’} due to unsignedness of other operand [-Wsign-compare]
  243 |  ne.pane = (target->wp != NULL ? target->wp->id : -1);
      |                                                   ^~
tty-keys.c: In function ‘tty_keys_next’:
tty-keys.c:1211:6: warning: ‘terminator’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 1211 |  end -= terminator - 1;
      |  ~~~~^~~~~~~~~~~~~~~~~
tty-keys.c:1162:17: note: ‘terminator’ was declared here
 1162 |  size_t    end, terminator, needed;
      |                 ^~~~~~~~~~
tty-term.c: In function ‘tty_term_read_list’:
tty-term.c:731:3: warning: ‘s’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  731 |   xasprintf(&(*caps)[*ncaps], "%s=%s", ent->name, s);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 /usr/bin/mkdir -p 'WD/bin'
  /usr/bin/install -c tmux 'WD/bin'

All the output messages are warnings, so I would have expected it to still compile, but it seems to hang here. Any ideas?

0 replies

albertfgu · 2023-04-12T18:32:08Z

albertfgu
Apr 12, 2023
Author

Sorry for not clarifying, I used the exact same command that @vladdoster showed above:

zinit for \
    as'null' \
    configure'--disable-utf8proc --prefix=$PWD --quiet' \
    make'PREFIX=$PWD --quiet install'\
    sbin \
  @tmux/tmux

1 reply

vladdoster Apr 14, 2023
Maintainer

@albertfgu looking into this

vladdoster · 2023-04-29T00:42:06Z

vladdoster
Apr 29, 2023
Maintainer

@albertfgu,

Try the following:

zinit for \
    as'null' \
    configure"--disable-utf8proc --prefix=$ZINIT[PLUGINS_DIR]/tmux --quiet" \
    id-as \
    make"PREFIX=$ZINIT[PLUGINS_DIR]/tmux --quiet install"\
    lbin'!' \
  @tmux/tmux

Context about the ices used:

id-as is used to make the location of the plugin deterministic. In this case, tmux.
Set prefix to the location of the plugin that you want to compile.
Profit?

If you are interested, @psprint and I don't quite agree on whether to use the plugin dir or $ZPFX as the prefix. See #458 for details.

IMO, it makes cleanup much more straightforward and ensures $ZPFX is not polluted with random compilation artifacts. Chime in if you have any opinions.

1 reply

vladdoster Apr 29, 2023
Maintainer

Context about the ices used:

id-as is used to make the location of the plugin deterministic. In this case, tmux.
Set prefix to the location of the plugin that you want to compile.
Profit?

If you are interested, @psprint and I don't quite agree on whether to use the plugin dir or $ZPFX as the prefix. See #458 for details.

IMO, it makes cleanup much more straightforward and ensures $ZPFX is not polluted with random compilation artifacts. Chime in if you have any opinions.

albertfgu · 2023-05-13T09:11:25Z

albertfgu
May 13, 2023
Author

I tried this command on a new machine and ran into the following message, which seems to have crashed my connection to the machine as well

Downloading lbin!… (at label: lbin!…)
Cloning into '/home/albertgu/.local/share/zinit/plugins/lbin!'...
remote: Not Found
fatal: repository 'https://github.com/lbin!/' not found

Clone failed (code: 128).

Downloading tmux/tmux…
Cloning into '/home/albertgu/.local/share/zinit/plugins/tmux---tmux'...
⠧ ███████████ OBJ: 100, PACK: 47093/47093, COMPR: 100%, REC: 100%, RES: 100%
==> Compiling autogen.sh [OK]
aclocal: error: 'configure.ac' is required
aclocal failed
Connection to <machine> closed.

0 replies

vladdoster · 2024-01-22T03:14:04Z

vladdoster
Jan 22, 2024
Maintainer

@albertfgu,

As of v3.13.0, tmux can be installed by running:

if [[ $OSTYPE =~ 'darwin*' ]]; then
    zinit configure'--disable-utf8proc' make for @tmux/tmux
else
    zinit build for @tmux/tmux
fi

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Help: tmux binary with bin-gem-node #391

{{title}}

Replies: 13 comments 3 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Help: tmux binary with bin-gem-node #391

albertfgu Oct 2, 2022

Replies: 13 comments · 3 replies

vladdoster Oct 29, 2022 Maintainer

albertfgu Oct 31, 2022 Author

vladdoster Nov 6, 2022 Maintainer

vladdoster Nov 6, 2022 Maintainer

vladdoster Nov 20, 2022 Maintainer

albertfgu Nov 29, 2022 Author

vladdoster Nov 30, 2022 Maintainer

albertfgu Nov 30, 2022 Author

vladdoster Nov 30, 2022 Maintainer

albertfgu Apr 11, 2023 Author

albertfgu Apr 12, 2023 Author

vladdoster Apr 14, 2023 Maintainer

vladdoster Apr 29, 2023 Maintainer

vladdoster Apr 29, 2023 Maintainer

albertfgu May 13, 2023 Author

vladdoster Jan 22, 2024 Maintainer

albertfgu
Oct 2, 2022

Replies: 13 comments 3 replies

vladdoster
Oct 29, 2022
Maintainer

albertfgu
Oct 31, 2022
Author

vladdoster Nov 6, 2022
Maintainer

vladdoster
Nov 6, 2022
Maintainer

vladdoster
Nov 20, 2022
Maintainer

albertfgu
Nov 29, 2022
Author

vladdoster
Nov 30, 2022
Maintainer

albertfgu
Nov 30, 2022
Author

vladdoster
Nov 30, 2022
Maintainer

albertfgu
Apr 11, 2023
Author

albertfgu
Apr 12, 2023
Author

vladdoster Apr 14, 2023
Maintainer

vladdoster
Apr 29, 2023
Maintainer

vladdoster Apr 29, 2023
Maintainer

albertfgu
May 13, 2023
Author

vladdoster
Jan 22, 2024
Maintainer