-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various ZIP and spec cleanups #789
Open
daira
wants to merge
6
commits into
zcash:main
Choose a base branch
from
daira:zip-324-update-index
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
daira
commented
Feb 24, 2024
•
edited
edited
- ZIP 324: use a workaround to make the 0-based list valid.
- ZIPs 316 and 317: cosmetics.
- Add the hyphen in Daira-Emma.
- Correct some author lists.
- Prevent line-breaking of given names or surnames in the spec.
- Protocol spec: cosmetics and improved indexing.
- Protocol spec: in 5.4.1.9 (Sinsemilla Hash Function), declare use of LEBS2IP instead of LE2OS2IP (fixes [protocol spec] Section 5.4.1.9 (Sinsemilla Hash Function) declares use of LEOS2IP when it should declare use of LEBS2IP #840).
- Acknowledge Conrado Gouvea.
daira
added
the
C-cleanup
Category: PRs that clean ZIPs up or issues documenting cleanup.
label
Feb 24, 2024
daira
changed the title
ZIP 324: use a workaround to make the 0-based list valid, and update index
Various ZIP and spec cleanups
Mar 3, 2024
daira
force-pushed
the
zip-324-update-index
branch
from
March 3, 2024 00:56
4a7d57b
to
783d3b6
Compare
daira
commented
Mar 3, 2024
daira
force-pushed
the
zip-324-update-index
branch
3 times, most recently
from
April 14, 2024 16:46
72f580f
to
a68370f
Compare
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…t line-breaking of given names or surnames in the spec. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…of LEOS2IP. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip-324-update-index
branch
from
May 28, 2024 19:31
90276be
to
62249d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.