Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check if the Base Directory Path is filled when enable HUD is checked. Leading to HUD not starting #826

Open
globeone opened this issue Oct 30, 2020 · 3 comments

Comments

@globeone
Copy link

Describe the bug
On the Weekly version of ZAP the HUD hasn't loaded in the browser for the last 4 or so weeks of versions. The HUD is enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Manual Explore
    1a. Enter a url "https://example.org"
  2. Click on enable HUD
  3. Scroll down to Chrome or Firefox
    3a. Click on Launch Browser
  4. See no HUD

Expected behavior
When launching the HUD, the HUD should show up in the browser

Screenshots
2020-10-30_OWASP ZAP-D-2020-10-26_HUDSettings
2020-10-29_OWASP ZAP D-2020-10-26-ChromeNoHud800x561
2020-10-29_OWASP ZAP D-2020-10-26-Firefox_No_HUD_800x604

Software versions

  • ZAP: D-2020-10-26

  • Add-on:
    D2020-10-26_InstalledPlugins.xlsx

  • OS: Windows 10

  • Java: Bellsoft Liberica JDK 15

  • Browser:
    Chrome: Version 86.0.4240.111 (Official Build) (64-bit)
    Firefox: 82.0.2 (64-bit)

Errors from the zap.log file
D2020-10-26_ZAPHUD_injectionhtmlNotFound.txt

Additional context
In the log file we see that the relative path to injectionHtml.html is incorrect. Java then defaults to a absolute path of No such file C:\target\injectionHtml.html that doesn't exist.
the absolute path being (for the weekly version)
C:\Users$USER\OWASP ZAP_D\hud\target\

Would you like to help fix this issue?
Happy to test and report bugs.

@psiinon psiinon transferred this issue from zaproxy/zaproxy Oct 30, 2020
@psiinon
Copy link
Member

psiinon commented Oct 30, 2020

Strictly speaking this looks like a local config issue, but no problem with trying to fix invalid or missing paths.

@globeone
Copy link
Author

So, there is no check if the Base Directory is blank in the options.

It would be desirable to have a check if the Base Directory field is filled when the 'enable HUD' option is checked to prevent this issue from occurring in the future.

@globeone globeone changed the title ZAP Weekly HUD not loading on any page injectionHTML.html not found due to invalid path ZAP Weekly HUD. No check if the Base Directory Path is filled when enable HUD is checked. Leading to HUD not starting Oct 30, 2020
@psiinon
Copy link
Member

psiinon commented Oct 30, 2020

Agreed :)

@thc202 thc202 changed the title ZAP Weekly HUD. No check if the Base Directory Path is filled when enable HUD is checked. Leading to HUD not starting No check if the Base Directory Path is filled when enable HUD is checked. Leading to HUD not starting Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants