Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP Access-Control-Allow-Origin header #753

Open
psiinon opened this issue May 22, 2020 · 7 comments
Open

Fix HTTP Access-Control-Allow-Origin header #753

psiinon opened this issue May 22, 2020 · 7 comments
Labels
bug Good First Issue This is a great issue for a first time contributor to start with.

Comments

@psiinon
Copy link
Member

psiinon commented May 22, 2020

If HTTP sites (is not HTTPS ones) use the Access-Control-Allow-Origin header then the site will typically not work.
ZAP should automatically fix this header.
https://stackoverflow.com/questions/61940616/how-do-i-work-with-http-sites-using-the-hud-in-owasps-zap-proxy

@psiinon psiinon added bug Good First Issue This is a great issue for a first time contributor to start with. labels May 22, 2020
@kingthorin kingthorin added the Hacktoberfest Issues which are good candidates for Hacktoberfest: https://hacktoberfest.digitalocean label Oct 3, 2020
@jveldhuijzen
Copy link

I'm willing to pick this up.
My plan was to update the Access-Control-Allow-Origin header in onHttpResponseReceive as described in the stackoverflow post.
I'm new to the gradle/java world and do not know how I can best debug this app? Any advice?

@kingthorin kingthorin removed the Hacktoberfest Issues which are good candidates for Hacktoberfest: https://hacktoberfest.digitalocean label Nov 21, 2020
jveldhuijzen pushed a commit to jveldhuijzen/zap-hud that referenced this issue Nov 21, 2020
@njmulsqb
Copy link
Contributor

Hi @psiinon , what's the status on this issue?

@thc202
Copy link
Member

thc202 commented Aug 30, 2021

Does not seem to be actively worked on.

@njmulsqb
Copy link
Contributor

Does not seem to be actively worked on.

I can see that @jveldhuijzen has pushed a commit, have you reviewed that?

@thc202
Copy link
Member

thc202 commented Aug 30, 2021

That's not a pull request (in any case that's not finished, e.g. setting other header).

@psiinon
Copy link
Member Author

psiinon commented Aug 31, 2021

For info ZAP already optionally strips out CSP.
The relevant code for this:

To fix this issue we'll need to do something similar.

@njmulsqb
Copy link
Contributor

image Is this message in HUD tutorial also explaining the current problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Good First Issue This is a great issue for a first time contributor to start with.
Development

No branches or pull requests

5 participants