Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: zappier push throws "spawn EINVAL" error #784

Closed
jaydamani opened this issue May 10, 2024 · 1 comment · Fixed by #788
Closed

[Bug]: zappier push throws "spawn EINVAL" error #784

jaydamani opened this issue May 10, 2024 · 1 comment · Fixed by #788
Labels
bug Something isn't working

Comments

@jaydamani
Copy link

jaydamani commented May 10, 2024

Bug Description

When you execute zapier push on a Windows system with Nodejs version 18.20.2. It results in the below error

✔ Copying project to temp directory
✖ Installing project dependencies
 »   Error: spawn EINVAL
 »
 »   re-run this command with `--debug` for more info

The same error is thrown by zapier test or any other command that tries to execute npm as part of it.
As a workaround you can use an older version of node like 18.12.0

Reproduction Steps

create an integration using zapier-cli on a windows device with Nodejs 18.20.2 (LTS) and execute zapier test or zapier push

Zapier Platform version

15.7.2

Node.js version

18.20.2

Your Operating System

Windows 10 (win32-x64)

npm/yarn version

10.5.0

App ID

No response

More Details

It is caused by runCommand function due to changes in child_process.spawn which now requires shell option to be true for executing .cmd or .bat commands. This change was from cve-2024-27980.

I would like to make a PR for this. Is it ok to just update the runCommand function to set shell as true?

@rnegron
Copy link
Member

rnegron commented May 27, 2024

Thanks for your bug report @jaydamani and apologies for the late response! I especially appreciate how you included the source of the problem in your report. I went ahead opened a quick fix PR here: #788

I'll make sure to give you a shoutout in the changelog for this patch release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants