Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): bump marked-terminal to fix peer dep issue #505

Closed
wants to merge 1 commit into from
Closed

fix(cli): bump marked-terminal to fix peer dep issue #505

wants to merge 1 commit into from

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Feb 28, 2022 •
edited

Fixes #489 by updating marked-terminal to a later version, which includes marked@4 as a peer dep.

@xavdid
Copy link
Contributor Author

xavdid commented Feb 28, 2022

Ah, looks like marked-terminal@5 requires Node.js 14, but we're still supporting node 12 until the end of april (2 more months), so we can't merge this for now.

Given that the CLI still installs and works successfully, i'll close this for now and set a reminder to re-open it when we can drop node 12.

@xavdid xavdid closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliangcs eliangcs Awaiting requested review from eliangcs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version conlfict between marked and marked-terminal
1 participant
@xavdid