Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipThrowForStatus overrides oauth2 autoRefresh #404

Open
sillypirate opened this issue Aug 3, 2021 · 2 comments
Open

skipThrowForStatus overrides oauth2 autoRefresh #404

sillypirate opened this issue Aug 3, 2021 · 2 comments

Comments

@sillypirate
Copy link

sillypirate commented Aug 3, 2021 •
edited

Bug Description

Whenever you have skipThrowForStatus: true, it supersedes the autoRefresh: true option in oauth2 setup, forcing developers to include a z.errors.RefreshAuthError() in their afterResponse middleware that autoRefresh: true should be handling.

Reproduction Steps

Set both skipThrowForStatus and autoRefresh to true. The autoRefresh will be ignored.

Version Info

  • Version info: 10.0.0+
  • Operating System:
  • App id: 68700
@zapzap
Copy link
Collaborator

zapzap commented Aug 10, 2021

This issue has been copied into our private issue tracker (as PDE-2624). Thanks for the report! We'll update this as we learn more.

@xavdid
Copy link
Contributor

xavdid commented Aug 10, 2021

Thanks @sillypirate! definitely seems like a bug; I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xavdid @zapzap @sillypirate