Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Proxy Support for CLI #403

Open
doara-developer opened this issue Aug 2, 2021 · 9 comments
Open

Enable Proxy Support for CLI #403

doara-developer opened this issue Aug 2, 2021 · 9 comments
Labels
cli Relates to `zapier-platform-cli` feature-request

Comments

@doara-developer
Copy link

doara-developer commented Aug 2, 2021

This issue has been copied into our private issue tracker (as PDE-2631). Thanks for the report! We'll update this as we learn more.

@doara-developer doara-developer added the question Further information is requested label Aug 2, 2021
@xavdid
Copy link
Contributor

xavdid commented Aug 10, 2021

hi @doara-developer, I am honestly not sure! I don't have any experience dealing with proxies. Do tools like curl work normally from your command line? Do they need any special setup? Afaik Zapier doesn't do anything special with regards to proxies, but I'm not sure what steps you'd need to take.

@doara-developer
Copy link
Author

doara-developer commented Aug 11, 2021

Thanks for reply.

OK. I confirmed source code and found to use node-fetch library for zapier-cli.
node-fetch doesn't support proxy natively, and need to use proxy-agent.

So, we should change this issue label to feature-request.
Can you change it? I don't have permission for change.

@xavdid xavdid added feature-request and removed question Further information is requested labels Aug 11, 2021
@xavdid xavdid changed the title How can I connect behind proxy? Enable Proxy Support for CLI Aug 11, 2021
@xavdid xavdid added the cli Relates to `zapier-platform-cli` label Aug 11, 2021
@xavdid
Copy link
Contributor

xavdid commented Aug 11, 2021

Got it! I've updated this issue's title and tags.

Off the top of my head, we'd probably add a line in a local config file to put the proxy address (a string, right?) and then use that in an example like this?

If that sounds right, we can add support for that.

Are you unable to use the Zapier CLI until we ship that?

@doara-developer
Copy link
Author

doara-developer commented Aug 12, 2021

Off the top of my head, we'd probably add a line in a local config file to put the proxy address (a string, right?) and then use that in an example like this?

Yes. It will work by implementing like your example.

Are you unable to use the Zapier CLI until we ship that?

I can use it by connecting without proxy. But, it's inconvenient for me.
I would appreciate it if you implement as soon as possible.

@zapzap
Copy link
Collaborator

zapzap commented Aug 12, 2021

This issue has been copied into our private issue tracker (as PDE-2632). Thanks for the report! We'll update this as we learn more.

@xavdid
Copy link
Contributor

xavdid commented Aug 12, 2021

Got it! It looks easy enough, we can probably get it out in our next release.

@doara-developer
Copy link
Author

Thank you. I'm waiting for your update.

@kreddlear
Copy link
Contributor

Hi there @doara-developer , unfortunately implementing this was more complex than we anticipated and thus was delayed indefinitely. I'm circling back on this -- are you still interested in this capability?

@doara-developer
Copy link
Author

Yes, I still interested in this feature.
I'd like to manage Zapier App in git and update by CI behind a proxy server.

Of course, I have some options without this feature.(e.g. change network setting)
However, it would be very helpful if this was implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Relates to `zapier-platform-cli` feature-request
Projects
None yet
Development

No branches or pull requests

4 participants