Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: list.perform is executed for sample data, but hook.outputFields is used instead of list.outputFields #353

Open
nitwhiz opened this issue Mar 23, 2021 · 2 comments

Comments

@nitwhiz
Copy link
Contributor

nitwhiz commented Mar 23, 2021

Current Behavior

When defining a resource with a hook action and a list action, the Zapier frontend executes list.perform to get sample data for further configuration. The output fields used to specify "what-is-what" are used from the hook definition, without falling back to the outputFields of the list operation.

Desired Behavior

If hook.ouputFields is undefined, fall back to list.outputFields or maybe don't even consider hook.outputFields if hook.performList is not defined. This makes sense because list.perform is executed anyways.

@xavdid
Copy link
Contributor

xavdid commented Apr 28, 2021

I believe this is fixable, but we'll have to dig into it a little more closely.

Thanks for the report!

@zapzap
Copy link
Collaborator

zapzap commented Apr 28, 2021

This issue has been copied into our private issue tracker (as PDE-2279). Thanks for the report! We'll update this as we learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants