Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/packager.io/preinstall.sh does not check the db adapter setting and fails if both psql and mysql are installed #5142

Closed
jr-timme opened this issue Apr 23, 2024 · 0 comments
Closed

contrib/packager.io/preinstall.sh does not check the db adapter setting and fails if both psql and mysql are installed #5142

jr-timme opened this issue Apr 23, 2024 · 0 comments
Labels
needs verification
Milestone
6.3

Comments

@jr-timme
Copy link
Contributor

Used Zammad Version

6.3

Environment

  • Installation method: deb package
  • Operating system (if you're unsure: cat /etc/os-release ): Debian 12 Bookworm
  • Database + version: MariaDB 10.11
  • Elasticsearch version: 7.10
  • Browser + version: n/a

Actual behaviour

When running Zammad with Mysql and also having psql installed on the same system the preinstall.sh script fails as it tries to connect to a non existing postgresql database

Expected behaviour

the script should also check the adapter setting in the database.yml and use the correct utility to check the availability of the database

Steps to reproduce the behaviour

  • Install Zammad with MySQL/MariaDB
  • Install psql-client on the same Server
  • try to upgrade through the debian packages

Support Ticket

No response

I'm sure this is a bug and no feature request or a general question.

yes
@jr-timme jr-timme mentioned this issue Apr 23, 2024
Closed
zammad-sync pushed a commit that referenced this issue May 8, 2024
@jr-timme @mgruner
Fixes: #5142 - contrib/packager.io/preinstall.sh does not check the d…
1a7a54d 
…b adapter setting and fails if both psql and mysql are installed

Make sure the correct database is used depending on the adapter setting
@mgruner mgruner added this to the 6.3 milestone May 8, 2024
zammad-sync pushed a commit that referenced this issue May 8, 2024
@jr-timme @mgruner
Fixes: #5142, closes: #5143 - contrib/packager.io/preinstall.sh does …
6baf144 
…not check the db adapter setting and fails if both psql and mysql are installed

Make sure the correct database is used depending on the adapter setting


(cherry picked from commit 506c295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs verification
Projects
None yet
Milestone
6.3
Development

Successfully merging a pull request may close this issue.

fixes #5142| fix db check in preinstall.sh jr-timme/zammad
2 participants
@mgruner @jr-timme