Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionalNamingForHostnames only works with zalando domains #1474

Open
JoacimV opened this issue Nov 24, 2023 · 1 comment
Open

FunctionalNamingForHostnames only works with zalando domains #1474

JoacimV opened this issue Nov 24, 2023 · 1 comment
Assignees

Comments

@JoacimV
Copy link

JoacimV commented Nov 24, 2023

As far as i can tell, it seems like the FunctionalNamingForHostnamesRule only work on zalando domains, i guess this must be a mistake?

https://github.com/zalando/zally/blob/main/server/zally-ruleset-zalando/src/test/kotlin/org/zalando/zally/ruleset/zalando/FunctionalNamingForHostnamesRuleTest.kt

@tkrop
Copy link
Member

tkrop commented Mar 7, 2024

Sorry for missing to answer timely. Yes, this is a mistake. We should have implemented the rule more general to allow customizing the domain used for the functional host name. You are welcome to make the rule configurable and contribute this back to Zally. Until we have done this, you can disable the rule by either using:

  1. Using x-zally-ignore: 224,
  2. Remove the rule from your jar-file, or
  3. Disable the rule by configuration in the application.yml by adding #zally/ingoreRules (see application.yml#L41).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants