Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom labels support for API reviews #1323

Open
vadeg opened this issue Oct 9, 2021 · 0 comments
Open

Add custom labels support for API reviews #1323

vadeg opened this issue Oct 9, 2021 · 0 comments
Labels
area: server Zally server issues type: enhancement

Comments

@vadeg
Copy link
Contributor

vadeg commented Oct 9, 2021

Add labels support to API review requests. Label is a key-value where both key and value are strings.

This has been partially implemented in #1162 by creating an additional table to store metrics. Since Zally use Postgres under the hood I think it would be better to leverage Postgres JSON capabilities (see my comment in the PR for details).
@vadeg vadeg added type: enhancement area: server Zally server issues labels Oct 9, 2021
@vadeg vadeg mentioned this issue Oct 9, 2021
Closed
@vadeg vadeg changed the title Add labels support for API reviews Add custom labels support for API reviews Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: server Zally server issues type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vadeg