Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALG_AZ_PREFIX variable is mandatory in Azure backup configuration #981

Open
uladzimir-tryputska opened this issue Mar 6, 2024 · 1 comment

Comments

@uladzimir-tryputska
Copy link

uladzimir-tryputska commented Mar 6, 2024

Spilo is using WALG_AZ_PREFIX environment variable as an indicator, that Azure cloud provider should be used for backups https://github.com/zalando/spilo/blob/3.2-p1/postgres-appliance/scripts/configure_spilo.py#L865

It makes usage of the default WALG_AZ_PREFIX value not possible https://github.com/zalando/spilo/blob/3.2-p1/postgres-appliance/scripts/configure_spilo.py#L898

Without default WALG_AZ_PREFIX it is not possible to use cluster uid in the bucket path names. zalando/postgres-operator#2227

AWS and GCP setup allows usage of the default WALG_PREFIX, because WALG_PREFIX is not mandatory and other variables can be used to enable backups, like here https://github.com/zalando/spilo/blob/3.2-p1/postgres-appliance/scripts/configure_spilo.py#L898

I would suggest to add more checks here https://github.com/zalando/spilo/blob/3.2-p1/postgres-appliance/scripts/configure_spilo.py#L898, like
elif wale.get("WALG_AZ_PREFIX") or wale.get("AZURE_STORAGE_ACCOUNT") or ... :

@youvegotmoxie
Copy link

I am also facing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants