Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes: support Ingress hostname with wildcards/regexp #284

Open
hjacobs opened this issue Feb 27, 2017 · 3 comments
Open

Kubernetes: support Ingress hostname with wildcards/regexp #284

hjacobs opened this issue Feb 27, 2017 · 3 comments

Comments

@hjacobs
Copy link
Contributor

hjacobs commented Feb 27, 2017

Hopefully the Kubernetes spec gets extended to define wildcard/regexp behavior: kubernetes/kubernetes#41881

@hjacobs
Copy link
Contributor Author

hjacobs commented Feb 27, 2017

@aryszka maybe you can describe how Skipper treats wildcards/regexp by default.

@schlomo
Copy link

schlomo commented Aug 29, 2017

I also need to create a wildcard subdomain like *.foo.bar.com.
FYI @mikkeloscar @tlossen

@szuecs szuecs changed the title Kubernetes: support Ingress wildcards/regexp Kubernetes: support Ingress hostname with wildcards/regexp Jun 9, 2018
@szuecs
Copy link
Member

szuecs commented Jun 9, 2018

@hjacobs I changed the title to match @schlomo's comment, because with #667 we support path-modes, which can be either Kubernetes API spec like, a Go regexp or PathSubtree match like in skipper. I prefer PathSubtree match, which does not lead to ambiguous routing trees and fits better the Kubernetes user documentation. We also switch our setup to PathSubtree in zalando-incubator/kubernetes-on-aws#1139 and dumped all ingresses to see if anyone is actual relying on regexps, and turns out no one is using regexps in our clusters.
Path handling is also documented in https://opensource.zalando.com/skipper/kubernetes/ingress-usage/#ingress-path-handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants