Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test_newClusterRateLimiter #2668

Open
AlexanderYastrebov opened this issue Oct 9, 2023 · 4 comments
Open

Flaky Test_newClusterRateLimiter #2668

AlexanderYastrebov opened this issue Oct 9, 2023 · 4 comments

Comments

@AlexanderYastrebov
Copy link
Member

--- FAIL: Test_newClusterRateLimiter (10.04s)
    redistest.go:39: Failed to start redis server: dial tcp 172.31.0.1:32768: i/o timeout: Connecting to Ryuk on 172.31.0.1:32768 failed: connecting to reaper failed: failed to create container
--- FAIL: TestLeakyBucketAdd (10.00s)
    redistest.go:39: Failed to start redis server: dial tcp 172.31.0.1:32768: i/o timeout: Connecting to Ryuk on 172.31.0.1:32768 failed: connecting to reaper failed: failed to create container
--- FAIL: TestLeakyBucketAddMoreThanCapacity (0.00s)
    redistest.go:39: Failed to start redis server: Error response from daemon: No such container: 72519353bdb24c6329518efa41f4f7ede8d3b93a3880adcd82d00fa30561f0a4: creating reaper failed: failed to create container
--- FAIL: TestLeakyBucketAddAtSlowRate (0.00s)
    redistest.go:39: Failed to start redis server: Error response from daemon: No such container: 72519353bdb24c6329518efa41f4f7ede8d3b93a3880adcd82d00fa30561f0a4: creating reaper failed: failed to create container
time="2023-10-09T16:17:57Z" level=info msg="create ring with addresses: [no-such-host.test:123]"
--- FAIL: TestLeakyBucketRedisStoredNumberPrecision (0.00s)
    redistest.go:39: Failed to start redis server: Error response from daemon: No such container: 72519353bdb24c6329518efa41f4f7ede8d3b93a3880adcd82d00fa30561f0a4: creating reaper failed: failed to create container
@AlexanderYastrebov
Copy link
Member Author

Looks similar to #2621

@szuecs
Copy link
Member

szuecs commented Oct 19, 2023

--- FAIL: Test_newClusterRateLimiter (22.40s)
    redistest.go:39: Failed to start redis server: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.41/containers/3830f064585cf818a3de5d19d9632a04f8896977a6beb4dc0e8ff0e37455ee6c/json": context deadline exceeded: creating reaper failed: failed to create container
2023/10/19 12:19:43 🔥 Reaper obtained from Docker for this test session 3830f064585cf818a3de5d19d9632a04f8896977a6beb4dc0e8ff0e37455ee6c

@szuecs
Copy link
Member

szuecs commented Oct 19, 2023

@AlexanderYastrebov yes same line number redistest.go:39

@szuecs
Copy link
Member

szuecs commented Dec 1, 2023

2023/12/01 15:56:51 github.com/testcontainers/testcontainers-go - Connected to docker: 
  Server Version: 20.10.23
  API Version: 1.41
  Operating System: Ubuntu 20.04.6 LTS
  Total Memory: 31628 MB
  Resolved Docker Host: unix:///var/run/docker.sock
  Resolved Docker Socket Path: /var/run/docker.sock
  Test SessionID: 0422e91b6644d3e9f1ad1516fa43a384a7731c1ef7ef6cf2480f3bf362dc22ce
  Test ProcessID: 45c70a8e-2b1a-49f7-80b8-1c97c08fdbfe
2023/12/01 15:56:51 🔥 Reaper obtained from Docker for this test session 98b82c26fdb6854e4dd45a9062a5d3b6aabc0184dafbf31ff84a2340fbc32b21
--- FAIL: Test_newClusterRateLimiter (10.03s)
    redistest.go:48: Failed to start redis server: dial tcp 172.31.16.1:32768: i/o timeout: Connecting to Ryuk on 172.31.16.1:32768 failed: connecting to reaper failed: failed to create container
--- FAIL: TestLeakyBucketAdd (10.00s)
    redistest.go:48: Failed to start redis server: dial tcp 172.31.16.1:32768: i/o timeout: Connecting to Ryuk on 172.31.16.1:32768 failed: connecting to reaper failed: failed to create container
--- FAIL: TestLeakyBucketAddMoreThanCapacity (0.00s)
    redistest.go:48: Failed to start redis server: Error response from daemon: No such container: 98b82c26fdb6854e4dd45a9062a5d3b6aabc0184dafbf31ff84a2340fbc32b21: creating reaper failed: failed to create container
--- FAIL: TestLeakyBucketAddAtSlowRate (0.00s)
    redistest.go:48: Failed to start redis server: Error response from daemon: No such container: 98b82c26fdb6854e4dd45a9062a5d3b6aabc0184dafbf31ff84a2340fbc32b21: creating reaper failed: failed to create container

time="2023-12-01T15:57:11Z" level=info msg="create ring with addresses: [no-such-host.test:123]"
--- FAIL: TestLeakyBucketRedisStoredNumberPrecision (0.00s)
    redistest.go:48: Failed to start redis server: Error response from daemon: No such container: 98b82c26fdb6854e4dd45a9062a5d3b6aabc0184dafbf31ff84a2340fbc32b21: creating reaper failed: failed to create container

AlexanderYastrebov added a commit that referenced this issue Feb 13, 2024
Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this issue Feb 13, 2024
Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants