Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate yaml configuration with a schema #929

Open
erthalion opened this issue Jan 15, 2019 · 2 comments
Open

Validate yaml configuration with a schema #929

erthalion opened this issue Jan 15, 2019 · 2 comments

Comments

@erthalion
Copy link
Contributor

Currently all the user-facing configuration is validated manually (sometimes on demand). So far it worked due to careful approach, but I think it's obvious that centralized declarative verification (using something like jsonschema) would be much less error prone and more convenient.

At the same time, since it potentially could be a breaking change to introduce such validation right away, it probably makes sense to report all the validation errors as warnings as the first step.

@redbaron
Copy link
Contributor

Do you think that logical conflicts such as #920 is within a scope of this issue?

@erthalion
Copy link
Contributor Author

Interesting point. Yes, I think this kind of configuration limitations also should be described and validated declarative using json schema (e.g. at some point have oneOf in the schema and enumerate valid combination of wal_level and logical replication slot). Of course @CyberDem0n is right, it's not an easy task to describe all the possible dependencies as this one, but we can try to start from something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants