logging: Log no action messages at debug level #2442
Conversation
|
Sorry, but just silencing log messages will not be accepted. |
Correct me if I am wrong, but the logging level can be changed from info to debug as part of the configuration. When changed the output will be logged. I certainly don't want to drop these log messages always, but instead to configure when they are produced |
|
The DEBUG level is too verbose. |
|
OK, when should the logs actually show heartbeat messages? From the issues I linked and the number of comments on each it seems logging these by default is not what users wish to see. How many users wish to see heartbeat messages every 10 seconds under the default configuration? That is a different question than how many users are indifferent. |
Issues don't always reflect the real world. The total amount of Patroni users is much higher than the number of users opening/commenting issues. |
|
OK, what would be accepted so that a user could drop any 'no action' messages from the log. Is a simple configuration option sufficient? |
|
@CyberDem0n Just nudging this one again. Would a non-default configuration option be accepted that silenced any 'no action' messages? If so I'm happy to write a PR and we can nut it out. |
There's a few issues floating around about the verbosity of logged messages that start with 'no action'. PR #2161 attempts to resolve this by reducing how often the messages are printed. This PR instead changes the severity level which is easy enough to reconfigure.
This should fix #1154, #1800 and #621. It would also help with #1203.