Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automated tests #12

Open
szuecs opened this issue Jan 23, 2016 · 6 comments
Open

Create automated tests #12

szuecs opened this issue Jan 23, 2016 · 6 comments
Assignees

Comments

@szuecs
Copy link
Member

szuecs commented Jan 23, 2016

Use https://github.com/coreos/dex to have an automated test setup with travis-ci as Brandon Philips pointed out. This will help to make it useful for non Zalando organizations, because it shows a usage that is not dependent to Zalando.

@LappleApple
Copy link
Contributor

Hey @szuecs, do you still want this? If so, I'd label "Help Wanted" and offer it to the Go community.

@szuecs
Copy link
Member Author

szuecs commented Feb 7, 2017

@LappleApple thank you for the hint :)

@chrishalbert
Copy link
Contributor

I'm interested in writing some tests if you'd like to assign it to me.

@chrishalbert
Copy link
Contributor

Thanks! I'll get started on that today.

@chrishalbert
Copy link
Contributor

@szuecs - I'm looking for clarification. At first, I thought the goal was to add test coverage via unit/integration tests. After reading the comment regarding dex from 2016, I started looking into the technology but I'm not entirely clear on the goal here. Did you envision us spinning up a dex container and mock out IdPs and then running examples using this library against the dex federator? Sorry for the confusion, and thanks for any further info!

@chrishalbert
Copy link
Contributor

Hey @szuecs - would it be ok if I just add unit tests to fulfill this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants