Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ToolWindow component #243

Open
targos opened this issue Oct 13, 2022 · 4 comments
Open

Create ToolWindow component #243

targos opened this issue Oct 13, 2022 · 4 comments
Assignees

Comments

@targos
Copy link
Member

targos commented Oct 13, 2022

Similar to VSCode with an icon to open it.

@stropitek
Copy link
Contributor

Do a POC based on:

cheminfo/nmrium#2782 (comment)

I would suggest that we create a new component ToolbarPanels

return (
<ToolbarPanels panels={[
    { id: 'panel1', renderPanel: () => <Accordion.Item ... />, icon: 'settings", isOpen: true }
  ]}
/>

The component could either be used as a controlled or uncontrolled component.

It would be in uncontrolled mode if another prop is passed (e.g. initialOpen={['panel1']}}. This is just a suggestion and the POC should focus on the controlled component.

@targos
Copy link
Member Author

targos commented Dec 18, 2023

I don't see the relation with toolbars (for the name).

@stropitek
Copy link
Contributor

I don't see the relation with toolbars (for the name).

Yes on second thought it's not semantically related.

In Webstorm they are called "Tool windows", in VS code the "Activity bar", I'm okay with the former.

@stropitek stropitek changed the title Create SidePanel component Create ToolWindow component Feb 20, 2024
@stropitek
Copy link
Contributor

@wadjih-bencheikh18 are you willing to take this on?

We want to do something that looks like a vertical toolbar, but opens panel windows. To give you something more visual, it would behave similarly to webstorm's "Tool windows":

CleanShot.2024-02-20.at.08.28.58.mp4

VSCode also has a similar concept but calls it "Activity bar".

Start by making the simplest possible POC:

  • A vertical toolbar, slighly bigger than our existing toolbar (including bigger icons)
  • Each tool can be on or off, and you can toggle their state by clicking on the toolbar.
  • Tools which are "on" render an accordion with some placeholder content. The accordions can be collapsed as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants