(Feature request) Add eslint

[Myzel394]

Preflight Checklist

• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe feature

A linter helps us having consistent code design

Additional Information

No response

[Myzel394]

@zadam what do you think?

[zadam]

I'm fine with it as an advisory tool, but not as a pre commit hook, auto formatter etc.

Also of course depends on the rule set.

[Myzel394]

I'm fine with it as an advisory tool, but not as a pre commit hook, auto formatter etc.

Why not? I think that would help us having a consistent codebase. For example: Double quotes or single quotes? Currently we use both kind of, which is a bit messy. With an auto formatter, we'd have it consistent.

[zadam]

It's a bikeshedding most of the time. "consistency" is in itself very vague goal without a clear practical benefit.

[Myzel394]

It's a bikeshedding most of the time

I agree with small projects, but for such a large app like Trilium Notes, I think it would be very beneficial.

"consistency" is in itself very vague goal without a clear practical benefit.

The benefit is that we will need less cognitive power to read the code because everything is formatted in a way we understand. This way, we can focus on the actual implementations and their problems, instead of trying to understand the code before we can actually implement it.

[meichthys]

Trilium has entered maintenance mode. Future enhancements will be addressed in TrilumNext: TriliumNext#138