Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger-state output constraint missing boolean support #221

Closed
optama opened this issue Mar 19, 2020 · 2 comments
Closed

trigger-state output constraint missing boolean support #221

optama opened this issue Mar 19, 2020 · 2 comments

Comments

@optama
Copy link

optama commented Mar 19, 2020

Describe the bug

Trigger-state node can't compare boolean states in output constraint

To Reproduce

  1. Create new trigger-state with a binary_sensor entity.
  2. Set "State type" to boolean.
  3. Expand "Add outputs"
  4. Instead of "send always" select "if state"
  5. As value to compare against type "true".
  6. Click "Add output"
  7. Check "show debug information"
  8. Connect third output (the added output) to a debug node.
  9. Deploy and trigger state change.
  10. Observe that debug node is not activated.
  11. trigger-state node debug output is
    output comparator failed: property "new_state.state" with value true failed "is" check against true

Expected behavior

A. debug node is activated.
B. But perhaps more fittingly a drop down where one can select the type of the value, as one can do when adding constraints (which works as expected)

Screenshots

Example Flow

Environment (please complete the following information):

  • Node Red Version: 1.0.4
  • Node.js Version: 12.16.1
  • NR Home Assistant Plugin Version: 6.1.3
  • Is Node Red running in Docker: HA addon

Other (please complete the following information):

  • Have you searched previous issues for duplicates?: Yes

Additional context

@github-actions
Copy link
Contributor

@optama: hello! 👋

This issue is being automatically closed because it does not follow the issue template.

Fixing this with automatically reopen the issue.

@optama
Copy link
Author

optama commented Mar 20, 2020

It seems like this has been fixed in commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants