Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amstrad CPC List Broken in IAGL 3.09 #286

Open
CFTBL opened this issue Apr 6, 2023 · 5 comments
Open

Amstrad CPC List Broken in IAGL 3.09 #286

CFTBL opened this issue Apr 6, 2023 · 5 comments

Comments

@CFTBL
Copy link

CFTBL commented Apr 6, 2023

Running IAGL on LibreELEC-RR on RPi4. When I attempt to open the Amstrad CPC List, "One Big List", I get an error and no list. It might be the Kodi infotag problem rearing its ugly head again. Here is the applicable section of the log...

2023-04-06 15:56:39.557 T:1035     info <general>: CActiveAESink::OpenSink - initialize sink
2023-04-06 15:56:39.558 T:1035     info <general>: CAESinkALSA::Initialize - Attempting to open device "hdmi:CARD=vc4hdmi0,DEV=0"
2023-04-06 15:56:39.564 T:1035     info <general>: CAESinkALSA::Initialize - Opened device "hdmi:CARD=vc4hdmi0,DEV=0,AES0=0x04,AES1=0x82,AES2=0x00,AES3=0x00"
2023-04-06 15:56:39.565 T:1035     info <general>: CAESinkALSA::InitializeHW - Your hardware does not support AE_FMT_FLOAT, trying other formats
2023-04-06 15:56:39.565 T:1035     info <general>: CAESinkALSA::InitializeHW - Using data format AE_FMT_S24NE3
2023-04-06 15:56:39.671 T:1199     info <general>: IAGL:  Lets Play!
2023-04-06 15:56:41.201 T:1199    error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'ValueError'>
                                                   Error Contents: could not convert string to float: '1 Player'
                                                   Traceback (most recent call last):
                                                     File "/storage/.kodi/addons/script.module.infotagger/resources/modules/infotagger/listitem.py", line 69, in set_info
                                                       func(v)
                                                   TypeError: must be real number, not str
                                                   
                                                   During handling of the above exception, another exception occurred:
                                                   
                                                   Traceback (most recent call last):
                                                     File "/storage/.kodi/addons/plugin.program.iagl/addon.py", line 902, in <module>
                                                       plugin.run(sys.argv)
                                                     File "/storage/.kodi/addons/script.module.routing/lib/routing.py", line 130, in run
                                                       self._dispatch(self.path)
                                                     File "/storage/.kodi/addons/script.module.routing/lib/routing.py", line 141, in _dispatch
                                                       view_func(**kwargs)
                                                     File "/storage/.kodi/addons/plugin.program.iagl/addon.py", line 354, in game_list_choose_category_from_list_route
                                                       plugin.redirect('/game_list/list_all/'+game_list_id+'/1')
                                                     File "/storage/.kodi/addons/script.module.routing/lib/routing.py", line 133, in redirect
                                                       self._dispatch(path)
                                                     File "/storage/.kodi/addons/script.module.routing/lib/routing.py", line 141, in _dispatch
                                                       view_func(**kwargs)
                                                     File "/storage/.kodi/addons/plugin.program.iagl/addon.py", line 308, in game_list_list_all_route
                                                       xbmcplugin.addDirectoryItems(plugin.handle,[(plugin.url_for_path('/game/%(game_list_id)s/%(label2)s'%{'label2':x.getLabel2(),'game_list_id':x.getProperty('route')}),x,True) for x in iagl_addon.game_lists.get_games_as_listitems(game_list_id=game_list_id) if x])
                                                                                                                                                                                                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/plugin.program.iagl/resources/lib/main.py", line 327, in get_games_as_listitems
                                                       return [self.add_game_context_menus(listitem_in=get_game_listitem(dict_in=x,filter_in=filter_in),game_list_id=game_list_id,game_id=x.get('values').get('label2'),is_favorite=(isinstance(x.get('properties').get('platform_category'),str) and 'favorites' in x.get('properties').get('platform_category').lower())) for x in self.get_games_from_cache(game_list_id=game_list_id) if x]
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/plugin.program.iagl/resources/lib/main.py", line 327, in <listcomp>
                                                       return [self.add_game_context_menus(listitem_in=get_game_listitem(dict_in=x,filter_in=filter_in),game_list_id=game_list_id,game_id=x.get('values').get('label2'),is_favorite=(isinstance(x.get('properties').get('platform_category'),str) and 'favorites' in x.get('properties').get('platform_category').lower())) for x in self.get_games_from_cache(game_list_id=game_list_id) if x]
                                                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/plugin.program.iagl/resources/lib/utils.py", line 981, in get_game_listitem
                                                       info_tag.set_info(dict_in.get('info'))
                                                     File "/storage/.kodi/addons/script.module.infotagger/resources/modules/infotagger/listitem.py", line 85, in set_info
                                                       func(_tag_attr['convert'](v))  # Attempt to force conversion to correct type
                                                            ^^^^^^^^^^^^^^^^^^^^^^^
                                                   ValueError: could not convert string to float: '1 Player'
                                                   -->End of Python script error report<--
                                                   
2023-04-06 15:56:41.345 T:1197    error <general>: GetDirectory - Error getting plugin://plugin.program.iagl/game_list/One Big List/Amstrad_CPC_ZachMorris
2023-04-06 15:56:41.359 T:1014    error <general>: CGUIMediaWindow::GetDirectory(plugin://plugin.program.iagl/game_list/One Big List/Amstrad_CPC_ZachMorris) failed
2023-04-06 15:56:41.437 T:1201     info <general>: IAGL:  Lets Play!
@ajbathe
Copy link

ajbathe commented Apr 9, 2023

same to me: http://ix.io/4t3a

@mczerski
Copy link

mczerski commented May 12, 2023

also trying to browse comodore c64 list alphabetically (actually any category):

2023-05-12 16:55:24.905 T:25499   error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--                                                             
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!                                                                                                                
                                                   Error Type: <class 'ValueError'>                                                                                                                                
                                                   Error Contents: could not convert string to float: 'Other - NR (Not Rated)'                                                                                     
                                                   Traceback (most recent call last):                                                                                                                              
                                                     File "/storage/.kodi/addons/script.module.infotagger/resources/modules/infotagger/listitem.py", line 69, in set_info                                          
                                                       func(v)                                                                                                                                                     
                                                   TypeError: must be real number, not str                                                                                                                         
                                                                                                                                                                                                                   
                                                   During handling of the above exception, another exception occurred:                                                                                             
                                                                                                                                                                                                                   
                                                   Traceback (most recent call last):                                                                                                                              
                                                     File "/storage/.kodi/addons/plugin.program.iagl/addon.py", line 902, in <module>                                                                              
                                                       plugin.run(sys.argv)                                                                                                                                        
                                                     File "/storage/.kodi/addons/script.module.routing/lib/routing.py", line 130, in run                                                                           
                                                       self._dispatch(self.path)                                                                                                                                   
                                                     File "/storage/.kodi/addons/script.module.routing/lib/routing.py", line 141, in _dispatch                                                                     
                                                       view_func(**kwargs)                                                                                                                                         
                                                     File "/storage/.kodi/addons/plugin.program.iagl/addon.py", line 388, in game_list_in_category_route                                                           
                                                       xbmcplugin.addDirectoryItems(plugin.handle,[(plugin.url_for_path('/game/%(game_list_id)s/%(label2)s'%{'label2':x.getLabel2(),'game_list_id':x.getProperty('r
                                                                                                                                                                                                                   
                                                     File "/storage/.kodi/addons/plugin.program.iagl/resources/lib/main.py", line 327, in get_games_as_listitems                                                   
                                                       return [self.add_game_context_menus(listitem_in=get_game_listitem(dict_in=x,filter_in=filter_in),game_list_id=game_list_id,game_id=x.get('values').get('labe
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/plugin.program.iagl/resources/lib/main.py", line 327, in <listcomp>                                                               
                                                       return [self.add_game_context_menus(listitem_in=get_game_listitem(dict_in=x,filter_in=filter_in),game_list_id=game_list_id,game_id=x.get('values').get('labe
                                                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                            
                                                     File "/storage/.kodi/addons/plugin.program.iagl/resources/lib/utils.py", line 981, in get_game_listitem                                                       
                                                       info_tag.set_info(dict_in.get('info'))                                                                                                                      
                                                     File "/storage/.kodi/addons/script.module.infotagger/resources/modules/infotagger/listitem.py", line 85, in set_info                                          
                                                       func(_tag_attr['convert'](v))  # Attempt to force conversion to correct type                                                                                
                                                            ^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                
                                                   ValueError: could not convert string to float: 'Other - NR (Not Rated)'                                                                                         
                                                   -->End of Python script error report<--                                                                                                                         
                                                                                                                                                                                                                   
2023-05-12 16:55:25.169 T:25497   error <general>: GetDirectory - Error getting plugin://plugin.program.iagl/game_list/category/Alphabetical/C/C64_ZachMorris/1                                                    
2023-05-12 16:55:25.178 T:10860   error <general>: CGUIMediaWindow::GetDirectory(plugin://plugin.program.iagl/game_list/category/Alphabetical/C/C64_ZachMorris/1) failed

@struckma
Copy link

Same for me:

2023-05-12 23:42:14.607 T:21792   debug <general>: IAGL:  Cache Size set to - 0 - Zero (Current Game Only)
2023-05-12 23:42:14.674 T:21792   debug <general>: [plugin.program.iagl][routing] Dispatching to 'game_list_in_category_route', args: {'category_choice': 'Alphabetical', 'category_value': 'B', 'game_list_id': 'Amstrad_CPC_ZachMorris', 'page_number': '1'}
2023-05-12 23:42:14.790 T:21792   error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'ValueError'>
                                                   Error Contents: could not convert string to float: '1-2 Players'
                                                   Traceback (most recent call last):
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\script.module.infotagger\resources\modules\infotagger\listitem.py", line 69, in set_info
                                                       func(v)
                                                   TypeError: must be real number, not str
                                                   
                                                   During handling of the above exception, another exception occurred:
                                                   
                                                   Traceback (most recent call last):
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\plugin.program.iagl\addon.py", line 902, in <module>
                                                       plugin.run(sys.argv)
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 130, in run
                                                       self._dispatch(self.path)
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\script.module.routing\lib\routing.py", line 141, in _dispatch
                                                       view_func(**kwargs)
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\plugin.program.iagl\addon.py", line 388, in game_list_in_category_route
                                                       xbmcplugin.addDirectoryItems(plugin.handle,[(plugin.url_for_path('/game/%(game_list_id)s/%(label2)s'%{'label2':x.getLabel2(),'game_list_id':x.getProperty('route')}),x,True) for x in iagl_addon.game_lists.get_games_as_listitems(game_list_id=game_list_id,filter_in=filter_dict) if x])
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\plugin.program.iagl\resources\lib\main.py", line 327, in get_games_as_listitems
                                                       return [self.add_game_context_menus(listitem_in=get_game_listitem(dict_in=x,filter_in=filter_in),game_list_id=game_list_id,game_id=x.get('values').get('label2'),is_favorite=(isinstance(x.get('properties').get('platform_category'),str) and 'favorites' in x.get('properties').get('platform_category').lower())) for x in self.get_games_from_cache(game_list_id=game_list_id) if x]
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\plugin.program.iagl\resources\lib\main.py", line 327, in <listcomp>
                                                       return [self.add_game_context_menus(listitem_in=get_game_listitem(dict_in=x,filter_in=filter_in),game_list_id=game_list_id,game_id=x.get('values').get('label2'),is_favorite=(isinstance(x.get('properties').get('platform_category'),str) and 'favorites' in x.get('properties').get('platform_category').lower())) for x in self.get_games_from_cache(game_list_id=game_list_id) if x]
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\plugin.program.iagl\resources\lib\utils.py", line 981, in get_game_listitem
                                                       info_tag.set_info(dict_in.get('info'))
                                                     File "C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\script.module.infotagger\resources\modules\infotagger\listitem.py", line 85, in set_info
                                                       func(_tag_attr['convert'](v))  # Attempt to force conversion to correct type
                                                   ValueError: could not convert string to float: '1-2 Players'
                                                   -->End of Python script error report<--
                                                   
2023-05-12 23:42:14.791 T:21792   debug <general>: CPythonInvoker::onExecutionDone(6, C:\Users\struckma.EXPRESSENCE\AppData\Roaming\Kodi\addons\plugin.program.iagl\addon.py)
2023-05-12 23:42:14.797 T:11904   debug <general>: ------ Window Init (DialogNotification.xml) ------
2023-05-12 23:42:14.819 T:21792   debug <general>: .
2023-05-12 23:42:14.884 T:21792   debug <general>: Python interpreter stopped
2023-05-12 23:42:14.884 T:21792   debug <general>: Thread LanguageInvoker 21792 terminating
2023-05-12 23:42:14.891 T:424     error <general>: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.program.iagl/game_list/category/Alphabetical/B/Amstrad_CPC_ZachMorris/1
2023-05-12 23:42:14.891 T:424     debug <general>: Thread waiting 424 terminating

@mczerski
Copy link

In resources/lib/utils.py commenting out line 980 and 981 then uncommenting line 982 solves issue for me.

@struckma
Copy link

#286 (comment) fixes it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants