Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z88dk-win32-2.3.zip is flagged by multiple anti-virus systems #2474

Open
PhilR73 opened this issue Jan 5, 2024 · 7 comments
Open

z88dk-win32-2.3.zip is flagged by multiple anti-virus systems #2474

PhilR73 opened this issue Jan 5, 2024 · 7 comments

Comments

@PhilR73
Copy link

PhilR73 commented Jan 5, 2024

It may well be a false positive, but multiple AV are detecting issues with this zip on Windows.

See https://www.virustotal.com/gui/file/665fcd1fa9b8f689af6dc3587b51e582759e297f7179ad896624ebc40194b6d5?nocache=1

When unzipping it on my system even Windows Defender (not the most robust AV) flagged issues with 'Wacatac'. File: "z88dk-win32-2.3\z88dk\src\z80asm\build_ldflags2229334.exe"

It would be worth double checking your build system is not compromised, just in case.

@pauloscustodio
Copy link
Member

build_ldflags2229334.exe looks suspicious, as it is not generated by the tool-chain. The original file is build_ldflags.pl

@suborb
Copy link
Member

suborb commented Jan 9, 2024

I think it must be some debris from the C++ filesystem detection that's not being cleaned:

-rwxrwxr-x  1 build build 287222 Jan  9 03:15 build_ldflags1306077.exe
-rwxrwxr-x  1 build build 287222 Jan  9 03:15 build_ldflags1306085.exe
-rwxrwxr-x  1 build build 287222 Jan  9 03:15 build_ldflags1306094.exe
-rwxrwxr-x  1 build build 287222 Jan  9 03:15 build_ldflags1306109.exe

build_ldflags.pl should probably cleanup after itself.

@suborb
Copy link
Member

suborb commented Feb 13, 2024

This has reared its head again - between this and Russian spammers on the forum I'm starting to wonder why I bother.

I've reviewed again, and I can see we have the following:

  • Most detections are by relatively unknown checkers
  • Most detections are by engines that use ML
  • Most detections are ML matches
  • The files with the most detections are z88dk-zx0 and z88dk-zx7 which are < 250 lines of code
  • Recompiling on my desktop also results in detections (admittedly fewer)

My desktop uses a different version of mingw (nightly is a 9.3 from 2020)

So pulling on that thread, it appears we're not alone:

amongst many others.

So, options:

  • Discontinue Windows builds
  • Upgrade mingw on the build machine and hope that it's not a wasted effort
  • Start reporting these false positives to the AV vendors
  • Use GitHub to build nightly packages for Visual Studio, upload binaries, let users combine binaries + libraries.
  • Only release Windows builds with manually built Visual Studio binaries
  • Live with it

@pauloscustodio
Copy link
Member

In my opinion, discontinuing Windows builds, or making it more difficult for users is not desirable. I can help on upgrading mingw on the build machine. Ideally we should do it on a clone, to be able to roll-back easily if it does not work as expected. Please let me know.

@suborb
Copy link
Member

suborb commented Feb 15, 2024

I wasn't being entirely serious about stopping building it!

Re-building the container is a pain - mainly gathering up the dependencies - my main concern is that even when it's done, some heuristic will perceive the binaries to be a threat - it seems to be a systemic result of building with mingw which triggers a false positive.

@JohnKozell
Copy link

I'm new to z88dk and received a similar virus notification. Not having any experience yet with z88dk so I was about to make knee-jerk reaction and remove it, thinking it was some cover for a virus scheme. But instead I was led to this post. I'm glad it was here as a known (and more importantly, unwanted) issue. I just wanted to mention this for context with other new-comers.
Can we just omit or change the implementation of this executable?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants