Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a mode in which it will populate the indexed images' EXIF data with tags #13

Open
yurijmikhalevich opened this issue Aug 25, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request priority:high High priority issues

Comments

@yurijmikhalevich
Copy link
Owner

yurijmikhalevich commented Aug 25, 2021

UPD: this feature is being worked on and will be released as a separate tool, rtag. You can follow the development by starring and watching the rtag repository. This Issue will be closed once rtag v1 is released.

Tags should be taken from a fixed, pre-defined set. The ImageNet competition tag list is a good place to start, wikientities is another one.

The v1 of the feature should look like this from the user perspective:

$ rclip tag
This operation will overwrite the tags stored in your images' EXIF metadata. This will change the image files and will make you loose any existing keywords stored on your images.
Proceed? y/n y
/photos [#####]

For v1, it should write the tags from the list of the ImageNet-1k tags, based on a certain threshold (should be determined empirically).

Interested user: https://www.youtube.com/watch?v=MsTgYdOpgcQ&lc=Ugzl8qVAiVsek_2TwoZ4AaABAg

@yurijmikhalevich yurijmikhalevich added the enhancement New feature or request label Sep 4, 2021
@yurijmikhalevich yurijmikhalevich added priority:high High priority issues priority:medium Medium priority issues and removed priority:high High priority issues labels Nov 17, 2021
@yburkouski
Copy link

If it will add (or override?) data to "Tags'' then it will be fine! I don't know, maybe someone is using that field for photo “catalogization”, so adding to the user custom tags could also be an option (but in that case we should not duplicate data during second run, could be complicated depending on implementation). And I think it's better to have a parameter for the number of tags to put, 10 by default.
image

@yurijmikhalevich
Copy link
Owner Author

Hi @yburkouski! Thank you for your interest and for sharing your thoughts. These are all valid points that are being considered. For the most part, you have literally described the design I have in mind :)

And I think it's better to have a parameter for the number of tags to put, 10 by default.

Having a confidence threshold instead of a hard number of tags will work better because it will allow getting in all high-confidence labels and ignoring everything else, even if there are only 3 high-confidence labels.

@stubkan
Copy link

stubkan commented Jan 11, 2024

Why not sidecar text files? Sidecars are normal for many image viewers / managers and dont touch the images themselves. Wouldn't be hard for python to append tags to a text file that has the same name as the images. You could also write the confidence levels of the tags into these files.

Then if one was inclined, there are then, many tools that work with sidecars to add or modify image metadata.

@yurijmikhalevich
Copy link
Owner Author

yurijmikhalevich commented Jan 13, 2024

@stubkan, that's an interesting suggestion. So, you are saying that you'd rather not let the tool modify your images. Right? I'll give it a closer look.

@yurijmikhalevich
Copy link
Owner Author

@stubkan, the XMP sidecar support will be implemented as a part of rtag

@yurijmikhalevich yurijmikhalevich added priority:high High priority issues and removed priority:medium Medium priority issues hacktoberfest labels Feb 27, 2024
@yurijmikhalevich yurijmikhalevich self-assigned this Mar 4, 2024
@rebelzion
Copy link

Why not sidecar text files? Sidecars are normal for many image viewers / managers and dont touch the images themselves. Wouldn't be hard for python to append tags to a text file that has the same name as the images. You could also write the confidence levels of the tags into these files.

Then if one was inclined, there are then, many tools that work with sidecars to add or modify image metadata.

What's a sidecar? just curious never heard of that. So you want to save a metadata file and not modify the image ?

@yburkouski
Copy link

yburkouski commented Apr 26, 2024

What's a sidecar? just curious never heard of that. So you want to save a metadata file and not modify the image ?

@rebelzion need assistance to open google.com? ;) "sidecar text file"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high High priority issues
Projects
None yet
Development

No branches or pull requests

4 participants