-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dapp csh #3
Merged
Merged
Dapp csh #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…process must be performed to find any missing step.
…order to support the function Summary.
…function of an ICO but still missing where it should be placed.
…riable was also replaced by `ICOid` to better label its function.
…n is still a pain in the neck.
…ction to lock 'vote' and ' bid' as well. However, how the remaining operations will get through in the future is still missing.
…ns that rely on offchain operations.
…ister with the variable 'Time to Market'. Updated the 'PowerUpResult' to better handle with variable value of 'Time To Market'. Created the 'minTimeToMarket' for better reading.
…the 'PowerUpResult'.
…ributed and the flowchart evaluation.
… can be reused by other functions. Fixed this calculation on 'AdmissionResult' and updated this calculation on 'PowerUpResult'.
…eferendum process before check for it status.
…enation of integers and strings. Some variables types was also changed.
This was
linked to
issues
Apr 7, 2020
Closed
Closed
This was
linked to
issues
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the improvements made so far. Most of them related to the code structure for readability and collaboration. However, a lot of tests are missing and the good file is kept apart.